Skip to content

Commit cf038e8

Browse files
svenefftingeroboquat
authored andcommitted
[admin] don't auto start search on page load
1 parent 7d7cec2 commit cf038e8

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

components/dashboard/src/admin/ProjectsSearch.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@ export function ProjectsSearch() {
3232
const [currentProjectOwner, setCurrentProjectOwner] = useState<string | undefined>("");
3333
const pageLength = 50;
3434
const [currentPage, setCurrentPage] = useState(1);
35-
useEffect(() => {
35+
const updateCurrentPage = (page: number) => {
36+
setCurrentPage(page);
3637
search();
37-
}, [currentPage]);
38+
};
3839

3940
useEffect(() => {
4041
const projectId = location.pathname.split("/")[3];
@@ -139,7 +140,7 @@ export function ProjectsSearch() {
139140
</div>
140141
<Pagination
141142
currentPage={currentPage}
142-
setPage={setCurrentPage}
143+
setPage={updateCurrentPage}
143144
totalNumberOfPages={Math.ceil(searchResult.total / pageLength)}
144145
/>
145146
</>

components/dashboard/src/admin/TeamsSearch.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@ export function TeamsSearch() {
3232
const [searchResult, setSearchResult] = useState<AdminGetListResult<Team>>({ total: 0, rows: [] });
3333
const pageLength = 50;
3434
const [currentPage, setCurrentPage] = useState(1);
35-
useEffect(() => {
35+
const updateCurrentPage = (page: number) => {
36+
setCurrentPage(page);
3637
search();
37-
}, [currentPage]);
38+
};
3839

3940
useEffect(() => {
4041
const teamId = location.pathname.split("/")[3];
@@ -128,7 +129,7 @@ export function TeamsSearch() {
128129
</div>
129130
<Pagination
130131
currentPage={currentPage}
131-
setPage={setCurrentPage}
132+
setPage={updateCurrentPage}
132133
totalNumberOfPages={Math.ceil(searchResult.total / pageLength)}
133134
/>
134135
</>

components/dashboard/src/admin/UserSearch.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,10 @@ export default function UserSearch() {
2222
const [currentUser, setCurrentUserState] = useState<User | undefined>(undefined);
2323
const pageLength = 50;
2424
const [currentPage, setCurrentPage] = useState(1);
25-
useEffect(() => {
25+
const updateCurrentPage = (page: number) => {
26+
setCurrentPage(page);
2627
search();
27-
}, [currentPage]);
28+
};
2829

2930
useEffect(() => {
3031
const userId = location.pathname.split("/")[3];
@@ -111,7 +112,7 @@ export default function UserSearch() {
111112
</div>
112113
<Pagination
113114
currentPage={currentPage}
114-
setPage={setCurrentPage}
115+
setPage={updateCurrentPage}
115116
totalNumberOfPages={Math.ceil(searchResult.total / pageLength)}
116117
/>
117118
</PageWithAdminSubMenu>

components/dashboard/src/admin/WorkspacesSearch.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,10 @@ export function WorkspaceSearch(props: Props) {
4747
const [currentWorkspace, setCurrentWorkspaceState] = useState<WorkspaceAndInstance | undefined>(undefined);
4848
const pageLength = 50;
4949
const [currentPage, setCurrentPage] = useState(1);
50-
useEffect(() => {
50+
const updateCurrentPage = (page: number) => {
51+
setCurrentPage(page);
5152
search();
52-
}, [currentPage]);
53+
};
5354

5455
useEffect(() => {
5556
const workspaceId = location.pathname.split("/")[3];
@@ -161,7 +162,7 @@ export function WorkspaceSearch(props: Props) {
161162
</div>
162163
<Pagination
163164
currentPage={currentPage}
164-
setPage={setCurrentPage}
165+
setPage={updateCurrentPage}
165166
totalNumberOfPages={Math.ceil(searchResult.total / pageLength)}
166167
/>
167168
</>

0 commit comments

Comments
 (0)