Skip to content

Commit ceb6937

Browse files
author
Andrea Falzetti
committed
feat: pass quality to code build
1 parent 41b5dfa commit ceb6937

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

WORKSPACE.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ defaultArgs:
88
publishToJBMarketplace: true
99
localAppVersion: unknown
1010
codeCommit: 30d694d1f41945af7f8d757d3ddf176b283752cb
11+
ideQuality: stable
1112
jetbrainsBackendQualifier: stable
1213
intellijDownloadUrl: "https://download.jetbrains.com/idea/ideaIU-2022.1.tar.gz"
1314
golandDownloadUrl: "https://download.jetbrains.com/go/goland-2022.1.tar.gz"

components/ide/code/BUILD.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@ packages:
99
argdeps:
1010
- imageRepoBase
1111
- codeCommit
12+
- ideQuality
1213
config:
1314
dockerfile: leeway.Dockerfile
1415
metadata:
1516
helm-component: workspace.codeImage
1617
buildArgs:
1718
CODE_COMMIT: ${codeCommit}
19+
IDE_QUALITY: ${ideQuality}
1820
image:
1921
- ${imageRepoBase}/ide/code:${version}
2022
- ${imageRepoBase}/ide/code:commit-${__git_commit}

components/ide/code/leeway.Dockerfile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ RUN yarn --cwd remote --frozen-lockfile --network-timeout 180000
1919
FROM gitpod/openvscode-server-linux-build-agent:bionic-x64 as code_builder
2020

2121
ARG CODE_COMMIT
22+
ARG IDE_QUALITY
2223

2324
ARG NODE_VERSION=16.14.2
2425
ARG NVM_DIR="/root/.nvm"
@@ -45,6 +46,11 @@ RUN yarn --frozen-lockfile --network-timeout 180000
4546
RUN rm -rf remote/node_modules/
4647
COPY --from=dependencies_builder /gp-code/remote/node_modules/ /gp-code/remote/node_modules/
4748

49+
# TODO: using jq, alter product.json to add IDE_QUALITY
50+
RUN cat product.json
51+
RUN echo "$(jq '. += {"quality":"1"}' product.json)" > product.json
52+
RUN cat product.json
53+
4854
RUN yarn --cwd extensions compile \
4955
&& yarn gulp vscode-web-min \
5056
&& yarn gulp vscode-reh-linux-x64-min

0 commit comments

Comments
 (0)