Skip to content

Commit bffbd32

Browse files
Furistoroboquat
authored andcommitted
Ensure session is only deleted once
1 parent a043243 commit bffbd32

File tree

1 file changed

+2
-2
lines changed
  • components/ws-daemon/pkg/internal/session

1 file changed

+2
-2
lines changed

components/ws-daemon/pkg/internal/session/store.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,13 @@ func (s *Store) Delete(ctx context.Context, name string) (err error) {
137137
if !exists {
138138
return nil
139139
}
140+
defer delete(s.workspaces, name)
140141

141142
err = session.Dispose(ctx)
142143
if err != nil {
143-
return xerrors.Errorf("cannot delete session: %w", err)
144+
return xerrors.Errorf("cannot delete session for workspace %s: %w", session.InstanceID, err)
144145
}
145146

146-
delete(s.workspaces, name)
147147
return nil
148148
}
149149

0 commit comments

Comments
 (0)