Skip to content

Commit bb76c47

Browse files
committed
Use the eventRecorder from manager object
Signed-off-by: JenTing Hsiao <[email protected]>
1 parent b9cfa13 commit bb76c47

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

components/ws-manager/pkg/manager/monitor.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,8 @@ import (
2626
k8serr "k8s.io/apimachinery/pkg/api/errors"
2727
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2828
"k8s.io/apimachinery/pkg/labels"
29-
"k8s.io/apimachinery/pkg/runtime"
3029
"k8s.io/apimachinery/pkg/types"
3130
"k8s.io/apimachinery/pkg/watch"
32-
covev1client "k8s.io/client-go/kubernetes/typed/core/v1"
3331
"k8s.io/client-go/tools/record"
3432
"sigs.k8s.io/controller-runtime/pkg/client"
3533

@@ -94,10 +92,6 @@ type Monitor struct {
9492

9593
// CreateMonitor creates a new monitor
9694
func (m *Manager) CreateMonitor() (*Monitor, error) {
97-
broadcaster := record.NewBroadcaster()
98-
broadcaster.StartRecordingToSink(&covev1client.EventSinkImpl{Interface: m.RawClient.CoreV1().Events("")})
99-
eventRecorder := broadcaster.NewRecorder(runtime.NewScheme(), corev1.EventSource{Component: "ws-manager"})
100-
10195
monitorInterval := time.Duration(m.Config.HeartbeatInterval)
10296
// Monitor interval is half the heartbeat interval to catch timed out workspaces in time.
10397
// See https://en.wikipedia.org/wiki/Nyquist%E2%80%93Shannon_sampling_theorem why we need this.
@@ -117,7 +111,7 @@ func (m *Manager) CreateMonitor() (*Monitor, error) {
117111

118112
notifyPod: make(map[string]chan string),
119113

120-
eventRecorder: eventRecorder,
114+
eventRecorder: m.eventRecorder,
121115
}
122116
res.eventpool = workpool.NewEventWorkerPool(res.handleEvent)
123117
res.act = struct {

0 commit comments

Comments
 (0)