Skip to content

Commit 58c99ca

Browse files
Christian WeichelArthurSens
Christian Weichel
authored andcommitted
Bump leeway to v0.2.0 to include linting
1 parent be14b48 commit 58c99ca

File tree

7 files changed

+11
-7
lines changed

7 files changed

+11
-7
lines changed

.gitpod.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:gpl-test-sh.1
1+
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:as-add-golangci-lint.6
22
workspaceLocation: gitpod/gitpod-ws.theia-workspace
33
checkoutLocation: gitpod
44
ports:

.werft/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ pod:
3030
- name: MYSQL_TCP_PORT
3131
value: 23306
3232
- name: build
33-
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:wth-update-terraform-0.13.5.8
33+
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:as-add-golangci-lint.6
3434
workingDir: /workspace
3535
imagePullPolicy: Always
3636
volumeMounts:

.werft/wipe-devstaging.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ pod:
1414
secretName: gcp-sa-gitpod-dev-deployer
1515
containers:
1616
- name: wipe-devstaging
17-
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:wth-update-terraform-0.13.5.8
17+
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:as-add-golangci-lint.6
1818
workingDir: /workspace
1919
imagePullPolicy: Always
2020
volumeMounts:

WORKSPACE.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ defaultArgs:
44
coreYarnLockBase: ../..
55
publishToNPM: true
66

7+
defaultVariant:
8+
config:
9+
go:
10+
lintCommand: ["golangci-lint", "run", "--disable", "govet,typecheck"]
11+
712
variants:
813
- name: oss
914
components:

components/docker-up/runc-facade/main.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ const (
2525
cmdUnmountProc = "unmount-proc"
2626
)
2727

28-
var log *logrus.Entry
29-
3028
func main() {
3129
log := logrus.New()
3230
log.SetLevel(logrus.DebugLevel)

dev/image/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ RUN cd /usr/local && curl -sfL https://install.goreleaser.com/github.com/golangc
4949

5050
# leeway
5151
ENV LEEWAY_NESTED_WORKSPACE=true
52-
RUN cd /usr/bin && curl -L https://github.com/TypeFox/leeway/releases/download/v0.1.0/leeway_0.1.0_Linux_x86_64.tar.gz | tar xz
52+
RUN cd /usr/bin && curl -L https://github.com/TypeFox/leeway/releases/download/v0.2.0/leeway_0.2.0_Linux_x86_64.tar.gz | tar xz
5353

5454
# dazzle
5555
RUN cd /usr/bin && curl -L https://github.com/32leaves/dazzle/releases/download/v0.0.3/dazzle_0.0.3_Linux_x86_64.tar.gz | tar xz

gitpod-ws.theia-workspace

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
"launch": {},
5454
"files.exclude": {
5555
"**/.git": true
56-
}
56+
},
57+
"go.lintTool": "golangci-lint"
5758
}
5859
}

0 commit comments

Comments
 (0)