Skip to content

Commit 49067e2

Browse files
committed
[jb] revert to previous solution if there is no proxy
1 parent 308188d commit 49067e2

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed

components/gitpod-protocol/java/src/main/java/io/gitpod/gitpodprotocol/api/GitpodServerLauncher.java

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,37 @@ public GitpodServerConnection listen(
7171
) throws Exception {
7272
String gitpodHost = URI.create(apiUrl).getHost();
7373
HttpClient httpClient;
74+
if (sslContext == null && proxies.size() == 0) {
75+
GitpodServerConnectionImpl connection = new GitpodServerConnectionImpl(gitpodHost);
76+
connection.setSession(ContainerProvider.getWebSocketContainer().connectToServer(new Endpoint() {
77+
@Override
78+
public void onOpen(Session session, EndpointConfig config) {
79+
session.addMessageHandler(new WebSocketMessageHandler(messageReader, jsonHandler, remoteEndpoint));
80+
messageWriter.setSession(session);
81+
client.notifyConnect();
82+
}
83+
84+
@Override
85+
public void onClose(Session session, CloseReason closeReason) {
86+
connection.complete(closeReason);
87+
}
88+
89+
@Override
90+
public void onError(Session session, Throwable thr) {
91+
GitpodServerConnectionImpl.LOG.log(Level.WARNING, gitpodHost + ": connection error:", thr);
92+
connection.completeExceptionally(thr);
93+
}
94+
}, ClientEndpointConfig.Builder.create().configurator(new ClientEndpointConfig.Configurator() {
95+
@Override
96+
public void beforeRequest(final Map<String, List<String>> headers) {
97+
headers.put("Origin", Arrays.asList(origin));
98+
headers.put("Authorization", Arrays.asList("Bearer " + token));
99+
headers.put("User-Agent", Arrays.asList(userAgent));
100+
headers.put("X-Client-Version", Arrays.asList(clientVersion));
101+
}
102+
}).build(), URI.create(apiUrl)));
103+
return connection;
104+
}
74105
if (sslContext == null) {
75106
httpClient = new HttpClient();
76107
} else {

components/ide/jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/latest/GitpodTerminalService.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,10 @@ class GitpodTerminalService(private val session: ClientProjectSession) {
208208
thisLogger().error("gitpod: Failed to forward port $hostPort from Supervisor's Terminal " +
209209
"${supervisorTerminal.pid}: $reason")
210210
}
211+
212+
override fun onPortForwardingEnded(hostPort: Int) {
213+
214+
}
211215
}
212216
}
213217

0 commit comments

Comments
 (0)