We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
instanceof
typeof
1 parent fdc317a commit 34e4dcbCopy full SHA for 34e4dcb
components/gitpod-protocol/src/util/tracing.ts
@@ -141,10 +141,7 @@ export namespace TraceContext {
141
try {
142
for (const k of Object.keys(keyValueMap)) {
143
const v = keyValueMap[k];
144
- // oh my JavaScript... `typeof null` and `typeof undefined` return `object`
145
- if (v !== null
146
- && v !== undefined
147
- && typeof v === 'object') {
+ if (v instanceof Object) {
148
addNestedTags(ctx, v, `${namespace}${k}`);
149
} else {
150
ctx.span.setTag(`${namespace}${k}`, v);
0 commit comments