[teams] don't show error if already in team

Author: AlexTugarev

components/dashboard/src/teams/JoinTeam.tsx

@@ -22,7 +22,21 @@ export default function() {
                 if (!inviteId) {
                     throw new Error('This invite URL is incorrect.');
                 }
-                const team = await getGitpodService().server.joinTeam(inviteId);
+
+                let team;
+                try {
+                    team = await getGitpodService().server.joinTeam(inviteId);
+                } catch (error) {
+                    const message: string | undefined = error && typeof error.message === "string" && error.message;
+                    const regExp = /You are already a member of this team. \((.*)\)/;
+                    const match = message && regExp.exec(message);
+                    if (match && match[1]) {
+                        const slug = match[1];
+                        history.push(`/t/${slug}/members`);
+                        return;
+                    }
+                    throw error;
+                }
                 const teams = await getGitpodService().server.getTeams();
                 setTeams(teams);
 
@@ -36,5 +50,5 @@ export default function() {
 
     useEffect(() => { document.title = 'Joining Team — Gitpod' }, []);
 
-    return <div className="mt-16 text-center text-gitpod-red">{String(joinError)}</div>
+    return joinError ? <div className="mt-16 text-center text-gitpod-red">{String(joinError)}</div> : <></>;
 }

components/gitpod-db/src/typeorm/team-db-impl.ts

@@ -154,7 +154,7 @@ export class TeamDBImpl implements TeamDB {
         const membershipRepo = await this.getMembershipRepo();
         const membership = await membershipRepo.findOne({ teamId, userId, deleted: false });
         if (!!membership) {
-            throw new Error('You are already a member of this team');
+            throw new Error(`You are already a member of this team. (${team.slug})`);
         }
         await membershipRepo.save({
             id: uuidv4(),