Skip to content

Commit 03a1418

Browse files
csweichelroboquat
authored andcommitted
[ws-manager] Fix validStartReq tests
1 parent 7fda2b3 commit 03a1418

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"error": "invalid request: workspace_image: cannot be blank; workspace_location: cannot be blank."
3-
}
2+
"error": "invalid request: type: value 200 is out of range."
3+
}

components/ws-manager/pkg/manager/testdata/validateStartReq_invalidType.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
"owner": "tester",
88
"metaId": "foobar"
99
},
10-
"servicePrefix": "foobarservice",
10+
"service_prefix": "foobarservice",
1111
"spec": {
1212
"ideImage": {
1313
"webRef": "eu.gcr.io/gitpod-core-dev/buid/theia-ide:someversion"
1414
},
15-
"workspaceImage": "eu.gcr.io/gitpod-dev/workspace-images/ac1c0755007966e4d6e090ea821729ac747d22ac/eu.gcr.io/gitpod-dev/workspace-base-images/github.com/typefox/gitpod:80a7d427a1fcd346d420603d80a31d57cf75a7af",
16-
"checkoutLocation": "/",
17-
"workspaceLocation": "/",
15+
"workspace_image": "eu.gcr.io/gitpod-dev/workspace-images/ac1c0755007966e4d6e090ea821729ac747d22ac/eu.gcr.io/gitpod-dev/workspace-base-images/github.com/typefox/gitpod:80a7d427a1fcd346d420603d80a31d57cf75a7af",
16+
"checkout_location": "/",
17+
"workspace_location": "/",
1818
"initializer": {
1919
"snapshot": {
2020
"snapshot": "workspaces/cryptic-id-goes-herg/fd62804b-4cab-11e9-843a-4e645373048e.tar@gitpod-dev-user-christesting"
@@ -37,4 +37,4 @@
3737
}
3838
}
3939
}
40-
}
40+
}
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
{
2-
"error": "invalid request: workspace_image: cannot be blank; workspace_location: cannot be blank."
3-
}
1+
{}

components/ws-manager/pkg/manager/testdata/validateStartReq_valid.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
"owner": "tester",
88
"metaId": "foobar"
99
},
10-
"servicePrefix": "foobarservice",
10+
"service_prefix": "foobarservice",
1111
"spec": {
1212
"ideImage": {
1313
"webRef": "eu.gcr.io/gitpod-core-dev/buid/theia-ide:someversion"
1414
},
15-
"workspaceImage": "eu.gcr.io/gitpod-dev/workspace-images/ac1c0755007966e4d6e090ea821729ac747d22ac/eu.gcr.io/gitpod-dev/workspace-base-images/github.com/typefox/gitpod:80a7d427a1fcd346d420603d80a31d57cf75a7af",
16-
"workspaceLocation": "/",
15+
"workspace_image": "eu.gcr.io/gitpod-dev/workspace-images/ac1c0755007966e4d6e090ea821729ac747d22ac/eu.gcr.io/gitpod-dev/workspace-base-images/github.com/typefox/gitpod:80a7d427a1fcd346d420603d80a31d57cf75a7af",
16+
"workspace_location": "/",
1717
"initializer": {
1818
"snapshot": {
1919
"snapshot": "workspaces/cryptic-id-goes-herg/fd62804b-4cab-11e9-843a-4e645373048e.tar@gitpod-dev-user-christesting"
@@ -36,4 +36,4 @@
3636
}
3737
}
3838
}
39-
}
39+
}

0 commit comments

Comments
 (0)