Skip to content

Commit 031cfab

Browse files
committed
Update also the "pluginSinceBuild" Gradle property when updating JetBrains Plugins via GitHub Action
1 parent af51108 commit 031cfab

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.github/workflows/jetbrains-update-plugin-platform-template.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ jobs:
6262
- name: Update ${{ inputs.gradlePropertiesPath }}
6363
if: ${{ steps.latest-version.outputs.result != steps.current-version.outputs.result }}
6464
run: |
65+
PLUGIN_SINCE_BUILD=$(echo "${{ steps.latest-version.outputs.result }}" | sed 's/-EAP-CANDIDATE-SNAPSHOT//' | sed 's/-CUSTOM-SNAPSHOT//')
66+
sed -i "s/pluginSinceBuild=.*/pluginSinceBuild=$PLUGIN_SINCE_BUILD/" ${{ inputs.gradlePropertiesPath }}
6567
sed -i 's/platformVersion=${{ steps.current-version.outputs.result }}/platformVersion=${{ steps.latest-version.outputs.result }}/' ${{ inputs.gradlePropertiesPath }}
6668
git diff
6769
- name: Create Pull Request for Gateway Plugin
@@ -90,7 +92,8 @@ jobs:
9092
commit-message: "Update Platform Version of ${{ inputs.pluginName }} to ${{ steps.latest-version.outputs.result }}"
9193
branch: "jetbrains/${{ inputs.pluginId }}-platform"
9294
labels: "team: IDE,editor: jetbrains"
93-
team-reviewers: "engineering-ide"
95+
# We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194
96+
# team-reviewers: "engineering-ide"
9497
- name: Create Pull Request for Backend Plugin
9598
if: ${{ inputs.pluginId == 'backend-plugin' && steps.latest-version.outputs.result != steps.current-version.outputs.result }}
9699
uses: peter-evans/create-pull-request@v4
@@ -119,14 +122,15 @@ jobs:
119122
commit-message: "Update Platform Version of ${{ inputs.pluginName }} to ${{ steps.latest-version.outputs.result }}"
120123
branch: "jetbrains/${{ inputs.pluginId }}-platform"
121124
labels: "team: IDE"
122-
team-reviewers: "engineering-ide"
125+
# We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194
126+
# team-reviewers: "engineering-ide"
123127
- name: Get previous job's status
124128
id: lastrun
125129
uses: filiptronicek/get-last-job-status@main
126130
- name: Slack Notification
127131
if: ${{ (success() && steps.lastrun.outputs.status == 'failed') || failure() }}
128132
uses: rtCamp/action-slack-notify@v2
129133
env:
130-
SLACK_WEBHOOK: ${{ secrets.slackWebhook }}
131-
SLACK_COLOR: ${{ job.status }}
132-
SLACK_TITLE: ${{ inputs.productName }}
134+
SLACK_WEBHOOK: ${{ secrets.slackWebhook }}
135+
SLACK_COLOR: ${{ job.status }}
136+
SLACK_TITLE: ${{ inputs.productName }}

.github/workflows/jetbrains-updates-template.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ jobs:
9090
commit-message: "[${{ inputs.productId }}] Update IDE image to build version ${{ steps.latest-release.outputs.version }}"
9191
branch: "jetbrains/${{ inputs.productId }}-${{ steps.latest-release.outputs.version2 }}"
9292
labels: "team: IDE,editor: jetbrains"
93-
team-reviewers: "engineering-ide"
93+
# We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194
94+
# team-reviewers: "engineering-ide"
9495
- name: Get previous job's status
9596
id: lastrun
9697
uses: filiptronicek/get-last-job-status@main

0 commit comments

Comments
 (0)