From 632279d454d90469be99d8f6059285e1a7524931 Mon Sep 17 00:00:00 2001 From: Jeremie Bresson Date: Thu, 28 Nov 2024 10:22:44 +0100 Subject: [PATCH 1/2] Don't use query param for the POST requests --- src/main/java/org/gitlab4j/api/EpicsApi.java | 4 ++-- src/main/java/org/gitlab4j/api/RunnersApi.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/gitlab4j/api/EpicsApi.java b/src/main/java/org/gitlab4j/api/EpicsApi.java index 009e3648..6f6a2a50 100644 --- a/src/main/java/org/gitlab4j/api/EpicsApi.java +++ b/src/main/java/org/gitlab4j/api/EpicsApi.java @@ -333,7 +333,7 @@ public Epic createEpic( .withParam("end_date", endDate) .withParam("created_at", createdAt); Response response = - post(Response.Status.CREATED, formData.asMap(), "groups", getGroupIdOrPath(groupIdOrPath), "epics"); + post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics"); return (response.readEntity(Epic.class)); } @@ -364,7 +364,7 @@ public Epic createEpic(Object groupIdOrPath, Epic epic) throws GitLabApiExceptio .withParam("end_date", epic.getEndDate()) .withParam("created_at", epic.getCreatedAt()); Response response = - post(Response.Status.CREATED, formData.asMap(), "groups", getGroupIdOrPath(groupIdOrPath), "epics"); + post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics"); return (response.readEntity(Epic.class)); } diff --git a/src/main/java/org/gitlab4j/api/RunnersApi.java b/src/main/java/org/gitlab4j/api/RunnersApi.java index c8d80b9b..fb42a0ad 100644 --- a/src/main/java/org/gitlab4j/api/RunnersApi.java +++ b/src/main/java/org/gitlab4j/api/RunnersApi.java @@ -530,7 +530,7 @@ public RunnerDetail registerRunner( .withParam("run_untagged", runUntagged, false) .withParam("tag_list", tagList, false) .withParam("maximum_timeout", maximumTimeout, false); - Response response = post(Response.Status.CREATED, formData.asMap(), "runners"); + Response response = post(Response.Status.CREATED, formData, "runners"); return (response.readEntity(RunnerDetail.class)); } From bb5b1498c333e28ed5e39500812ad013179aaab7 Mon Sep 17 00:00:00 2001 From: Jeremie Bresson Date: Thu, 28 Nov 2024 13:40:24 +0100 Subject: [PATCH 2/2] fix format --- src/main/java/org/gitlab4j/api/EpicsApi.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/gitlab4j/api/EpicsApi.java b/src/main/java/org/gitlab4j/api/EpicsApi.java index 6f6a2a50..b2a292fc 100644 --- a/src/main/java/org/gitlab4j/api/EpicsApi.java +++ b/src/main/java/org/gitlab4j/api/EpicsApi.java @@ -332,8 +332,7 @@ public Epic createEpic( .withParam("start_date", startDate) .withParam("end_date", endDate) .withParam("created_at", createdAt); - Response response = - post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics"); + Response response = post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics"); return (response.readEntity(Epic.class)); } @@ -363,8 +362,7 @@ public Epic createEpic(Object groupIdOrPath, Epic epic) throws GitLabApiExceptio .withParam("start_date", epic.getStartDate()) .withParam("end_date", epic.getEndDate()) .withParam("created_at", epic.getCreatedAt()); - Response response = - post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics"); + Response response = post(Response.Status.CREATED, formData, "groups", getGroupIdOrPath(groupIdOrPath), "epics"); return (response.readEntity(Epic.class)); }