From 59b71172018b0f2fa33dbb0d19833895a7ef11fa Mon Sep 17 00:00:00 2001
From: Mu-An Chiou <me@muanchiou.com>
Date: Thu, 14 Mar 2019 17:31:29 -0400
Subject: [PATCH 1/2] Update event name, documents, and remove bubbles

---
 README.md                 | 4 ++--
 examples/index.html       | 8 ++++----
 src/task-lists-element.js | 6 ++----
 test/test.js              | 4 ++--
 4 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/README.md b/README.md
index 034828e..7fd904b 100644
--- a/README.md
+++ b/README.md
@@ -45,12 +45,12 @@ import '@github/task-lists-element'
 ```js
 const list = document.querySelector('task-lists')
 
-list.addEventListener('task-lists:check', function(event) {
+list.addEventListener('task-lists-check', function(event) {
   const {position, checked} = event.detail
   console.log(position, checked)
 })
 
-list.addEventListener('task-lists:move', function(event) {
+list.addEventListener('task-lists-move', function(event) {
   const {src, dst} = event.detail
   console.log(src, dst)
 })
diff --git a/examples/index.html b/examples/index.html
index c93faf9..378dc18 100644
--- a/examples/index.html
+++ b/examples/index.html
@@ -62,12 +62,12 @@
   <pre class="events"></pre>
   <script type="text/javascript">
     const events = document.querySelector('.events')
-    document.addEventListener('task-lists:check', function(event) {
-      events.append(`task-lists:check - checked: ${event.detail.checked}, position: ${event.detail.position}\n`)
+    document.addEventListener('task-lists-check', function(event) {
+      events.append(`task-lists-check - checked: ${event.detail.checked}, position: ${event.detail.position}\n`)
     })
 
-    document.addEventListener('task-lists:move', function(event) {
-      events.append(`task-lists:move - from: ${event.detail.src}, to: ${event.detail.dst}\n`)
+    document.addEventListener('task-lists-move', function(event) {
+      events.append(`task-lists-move - from: ${event.detail.src}, to: ${event.detail.dst}\n`)
     })
   </script>
 </body>
diff --git a/src/task-lists-element.js b/src/task-lists-element.js
index 6b83b36..48fa383 100644
--- a/src/task-lists-element.js
+++ b/src/task-lists-element.js
@@ -14,8 +14,7 @@ export default class TaskListsElement extends HTMLElement {
       if (!checkbox.classList.contains('task-list-item-checkbox')) return
 
       this.dispatchEvent(
-        new CustomEvent('task-lists:check', {
-          bubbles: true,
+        new CustomEvent('task-lists-check', {
           detail: {
             position: position(checkbox),
             checked: checkbox.checked
@@ -207,8 +206,7 @@ function onSorted({src, dst}) {
   originalLists.delete(container)
 
   container.dispatchEvent(
-    new CustomEvent('task-lists:move', {
-      bubbles: true,
+    new CustomEvent('task-lists-move', {
       detail: {
         src: [lists.indexOf(src.list), src.index],
         dst: [lists.indexOf(dst.list), dst.index]
diff --git a/test/test.js b/test/test.js
index b55db11..b279dd9 100644
--- a/test/test.js
+++ b/test/test.js
@@ -69,7 +69,7 @@ describe('task-lists element', function() {
       let called = false
 
       const list = document.querySelector('task-lists')
-      list.addEventListener('task-lists:check', function(event) {
+      list.addEventListener('task-lists-check', function(event) {
         called = true
         const {position, checked} = event.detail
         assert.deepEqual(position, [1, 1])
@@ -87,7 +87,7 @@ describe('task-lists element', function() {
       let called = false
 
       const list = document.querySelector('task-lists')
-      list.addEventListener('task-lists:check', function(event) {
+      list.addEventListener('task-lists-check', function(event) {
         called = true
         const {position, checked} = event.detail
         assert.deepEqual(position, [4, 0])

From 3e9e4d9f9a24cfc809c0ac5f8bf450ff7c4cc89a Mon Sep 17 00:00:00 2001
From: Mu-An Chiou <me@muanchiou.com>
Date: Thu, 4 Apr 2019 18:36:03 -0400
Subject: [PATCH 2/2] Add bubbles back

---
 src/task-lists-element.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/task-lists-element.js b/src/task-lists-element.js
index 48fa383..b47aa9b 100644
--- a/src/task-lists-element.js
+++ b/src/task-lists-element.js
@@ -15,6 +15,7 @@ export default class TaskListsElement extends HTMLElement {
 
       this.dispatchEvent(
         new CustomEvent('task-lists-check', {
+          bubbles: true,
           detail: {
             position: position(checkbox),
             checked: checkbox.checked
@@ -207,6 +208,7 @@ function onSorted({src, dst}) {
 
   container.dispatchEvent(
     new CustomEvent('task-lists-move', {
+      bubbles: true,
       detail: {
         src: [lists.indexOf(src.list), src.index],
         dst: [lists.indexOf(dst.list), dst.index]