Merge pull request #26 from github/fix-bug-25

koddsson · web-flow · commit f802bef26297 · 2021-08-04T11:50:42.000+01:00
Fix: Compute the task list item index correctly.
diff --git a/src/task-lists-element.ts b/src/task-lists-element.ts
@@ -132,7 +132,8 @@ function position(checkbox: HTMLInputElement): [number, number] {
   const list = taskList(checkbox)
   if (!list) throw new Error('.contains-task-list not found')
   const item = checkbox.closest('.task-list-item')
-  const index = item ? Array.from(list.children).indexOf(item) : -1
+  const listItems = Array.from(list.children).filter(el => el.classList.contains('task-list-item'))
+  const index = item ? listItems.indexOf(item) : -1
   return [listIndex(list), index]
 }
 

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,8 @@ function position(checkbox: HTMLInputElement): [number, number] {`
`132`	`132`	`const list = taskList(checkbox)`
`133`	`133`	`if (!list) throw new Error('.contains-task-list not found')`
`134`	`134`	`const item = checkbox.closest('.task-list-item')`
`135`		`- const index = item ? Array.from(list.children).indexOf(item) : -1`
	`135`	`+ const listItems = Array.from(list.children).filter(el => el.classList.contains('task-list-item'))`
	`136`	`+ const index = item ? listItems.indexOf(item) : -1`
`136`	`137`	`return [listIndex(list), index]`
`137`	`138`	`}`
`138`	`139`