Skip to content

TypeScript conversion #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 22, 2020
Merged

TypeScript conversion #138

merged 15 commits into from
Sep 22, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented May 29, 2020 •
edited
Loading

  • TypeScript
  • Remove UMD build
  • Start running tests on GitHub Actions
  • Upgrade dependencies
  • Remove Travis CI config
  • Add CODEOWNERS
  • Upgrade demo page (remove polyfills + make it work on ghpages)

The typescript type definition for RelativeTimeFormat is also not yet released: microsoft/TypeScript#36084

  • Still waiting. Looks like it's getting released into v4. a3f88fd

@koddsson koddsson mentioned this pull request Jun 1, 2020
Merged
@keithamus keithamus changed the base branch from master to main August 3, 2020 15:32
@muan muan marked this pull request as ready for review September 21, 2020 22:24
@muan muan requested a review from a team September 21, 2020 22:25
keithamus
keithamus approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

koddsson
koddsson approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@muan muan merged commit 4414cba into main Sep 22, 2020
@keithamus keithamus deleted the ts branch October 19, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@keithamus keithamus keithamus approved these changes

@koddsson koddsson koddsson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muan @keithamus @koddsson