From 07193f786f531fda4bc7eb072bc1657ea851f8ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Mon, 25 Nov 2019 10:50:21 +0000 Subject: [PATCH 1/2] add rule `no-implied-eval` --- lib/configs/recommended.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/configs/recommended.js b/lib/configs/recommended.js index 347cc243..37919a59 100644 --- a/lib/configs/recommended.js +++ b/lib/configs/recommended.js @@ -65,6 +65,7 @@ module.exports = { 'no-func-assign': 'error', 'no-global-assign': 'error', 'no-implicit-globals': 'error', + 'no-implied-eval': 'error', 'no-inner-declarations': 'error', 'no-invalid-regexp': 'error', 'no-invalid-this': 'error', From e2ddff12b9ab61f1900cdeae9c33e3d619088b35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Mon, 25 Nov 2019 10:52:19 +0000 Subject: [PATCH 2/2] sort reccomended rules --- lib/configs/recommended.js | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/lib/configs/recommended.js b/lib/configs/recommended.js index 37919a59..45f5170e 100644 --- a/lib/configs/recommended.js +++ b/lib/configs/recommended.js @@ -4,21 +4,14 @@ module.exports = { commonjs: true }, rules: { - camelcase: ['error', {properties: 'always'}], 'constructor-super': 'error', - eqeqeq: ['error', 'smart'], - 'eslint-comments/no-unused-enable': 'error', - 'eslint-comments/no-unused-disable': 'error', 'eslint-comments/disable-enable-pair': 'off', 'eslint-comments/no-aggregating-enable': 'off', 'eslint-comments/no-duplicate-disable': 'error', 'eslint-comments/no-unlimited-disable': 'error', - 'eslint-comments/no-use': [ - 'error', - { - allow: ['eslint', 'eslint-disable-next-line', 'eslint-env', 'globals'] - } - ], + 'eslint-comments/no-unused-disable': 'error', + 'eslint-comments/no-unused-enable': 'error', + 'eslint-comments/no-use': ['error', {allow: ['eslint', 'eslint-disable-next-line', 'eslint-env', 'globals']}], 'func-style': ['error', 'declaration', {allowArrowFunctions: true}], 'github/no-implicit-buggy-globals': 'error', 'jsdoc/check-alignment': 'error', @@ -30,17 +23,17 @@ module.exports = { 'jsdoc/implements-on-classes': 'error', 'jsdoc/match-description': 'error', 'jsdoc/newline-after-description': 'error', - 'jsdoc/require-description-complete-sentence': 'error', 'jsdoc/require-description': 'error', + 'jsdoc/require-description-complete-sentence': 'error', 'jsdoc/require-hyphen-before-param-description': 'error', + 'jsdoc/require-param': 'error', 'jsdoc/require-param-description': 'error', 'jsdoc/require-param-name': 'error', 'jsdoc/require-param-type': 'error', - 'jsdoc/require-param': 'error', + 'jsdoc/require-returns': 'error', 'jsdoc/require-returns-check': 'error', 'jsdoc/require-returns-description': 'error', 'jsdoc/require-returns-type': 'error', - 'jsdoc/require-returns': 'error', 'jsdoc/valid-types': 'error', 'no-case-declarations': 'error', 'no-class-assign': 'error', @@ -56,9 +49,9 @@ module.exports = { 'no-dupe-class-members': 'error', 'no-dupe-keys': 'error', 'no-duplicate-case': 'error', + 'no-empty': 'error', 'no-empty-character-class': 'error', 'no-empty-pattern': 'error', - 'no-empty': 'error', 'no-ex-assign': 'error', 'no-extra-boolean-cast': 'error', 'no-fallthrough': 'error', @@ -94,6 +87,8 @@ module.exports = { 'prettier/prettier': 'error', 'require-yield': 'error', 'use-isnan': 'error', - 'valid-typeof': 'error' + 'valid-typeof': 'error', + camelcase: ['error', {properties: 'always'}], + eqeqeq: ['error', 'smart'] } }