-
Notifications
You must be signed in to change notification settings - Fork 62.5k
doc(securing-your-webhooks): show test values #27263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@coolaj86 Thanks so much for submitting a PR! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I'm going to modify the format a bit, then we'll get this merged for you.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
We know that:
Lists are almost always the worst representation for data - right behind paragraphs. A table might be better in both cases. A code block is acceptable. I don't really think it needs more words. There's already a lot of duplicate information and - much like code, more sentences means more things that have to be maintained. Less is more. That said, SEO or whatever, tomato potato. Maybe there's an advantage to more words. That might be subjective. I'd prefer just an easy to copy/paste block. Meh. However, converting easily digestible code blocks into difficult-to-read lists... definitely no bueno. |
This comment was marked as spam.
This comment was marked as spam.
@coolaj86 You can read more about GitHub's commitment to accessibility in https://github.blog/2022-12-02-github-accessibility-and-the-disability-divide/ |
Why:
It's always good to have test values to know that a subtle difference in implementation isn't causing buggy behavior.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Adding test values.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.