Skip to content

Commit 8ec825b

Browse files
authored
deprecate GHES 3.5 (#38775)
1 parent e513eb3 commit 8ec825b

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

content/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,8 @@ The self-hosted runner connects to {% data variables.product.product_name %} to
146146
Since the self-hosted runner opens a connection to {% data variables.location.product_location %}, you do not need to allow {% data variables.product.prodname_dotcom %} to make inbound connections to your self-hosted runner.
147147
{% elsif ghes or ghae %}
148148
Only an outbound connection from the runner to {% data variables.location.product_location %} is required. There is no need for an inbound connection from {% data variables.location.product_location %} to the runner.
149-
{% ifversion ghes > 3.4%}
150149
For caching to work, the runner must be able to communicate with the blob storage and directly download content from it.
151150
{%- endif %}
152-
{%- endif %}
153151

154152
{% ifversion ghes %}
155153

lib/enterprise-server-releases.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const dates = JSON.parse(await fs.readFile('src/ghes-releases/lib/enterpr
1212
export const next = '3.10'
1313
export const nextNext = '3.11'
1414

15-
export const supported = ['3.9', '3.8', '3.7', '3.6', '3.5']
15+
export const supported = ['3.9', '3.8', '3.7', '3.6']
1616

1717
// Ensure that:
1818
// "next" is ahead of "latest" by one minor or major release.
@@ -37,7 +37,7 @@ function isValidNext(v1, v2) {
3737
// When you're archiving a version, add the new archived number to this
3838
// array and you should never need to touch the `deprecated` array
3939
// on the line just below.
40-
export const deprecatedWithFunctionalRedirects = ['3.4', '3.3', '3.2', '3.1', '3.0']
40+
export const deprecatedWithFunctionalRedirects = ['3.5', '3.4', '3.3', '3.2', '3.1', '3.0']
4141
export const deprecated = [
4242
...deprecatedWithFunctionalRedirects,
4343
'2.22',

tests/fixtures/content/get-started/liquid/ifversion.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ condition-e
3131

3232
## ifversion with ranges
3333

34-
{% ifversion ghes > 3.4 %}
34+
{% ifversion ghes > 3.5 %}
3535
condition-f
3636
{% endif %}
3737

38-
{% ifversion ghes < 3.6 %}
38+
{% ifversion ghes < 3.7 %}
3939
condition-g
4040
{% endif %}
4141

42-
{% ifversion ghes > 3.4 and ghes < 3.6 %}
42+
{% ifversion ghes > 3.5 and ghes < 3.7 %}
4343
condition-h
4444
{% endif %}
4545

@@ -49,11 +49,11 @@ condition-h
4949
condition-i
5050
{% endif %}
5151

52-
{% ifversion ghes != 3.5 %}
52+
{% ifversion ghes != 3.6 %}
5353
condition-j
5454
{% endif %}
5555

56-
{% ifversion ghes = 3.5 %}
56+
{% ifversion ghes = 3.6 %}
5757
condition-k
5858
{% endif %}
5959

@@ -67,13 +67,13 @@ condition-l
6767

6868
{% ifversion ghes %}
6969
condition-m
70-
{% ifversion ghes = 3.5 %}
70+
{% ifversion ghes = 3.6 %}
7171
condition-n
7272
{% endif %}
7373
{% endif %}
7474

7575
## ifversion combined operations
7676

77-
{% ifversion not fpt and ghes > 3.4 %}
77+
{% ifversion not fpt and ghes > 3.5 %}
7878
condition-o
7979
{% endif %}

tests/rendering-fixtures/liquid.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ describe('extended Markdown', () => {
154154
'condition-l',
155155
],
156156
'enterprise-cloud@latest': ['condition-c', 'condition-j', 'condition-l'],
157-
'enterprise-server@3.5': [
157+
'enterprise-server@3.6': [
158158
'condition-c',
159159
'condition-e',
160160
'condition-f',
@@ -166,7 +166,7 @@ describe('extended Markdown', () => {
166166
'condition-n',
167167
'condition-o',
168168
],
169-
'enterprise-server@3.6': [
169+
'enterprise-server@3.7': [
170170
'condition-c',
171171
'condition-e',
172172
'condition-f',

0 commit comments

Comments
 (0)