Skip to content

Commit 8c20a9c

Browse files
authored
remove LFS from codebase (#33777)
1 parent fbfc550 commit 8c20a9c

File tree

13 files changed

+12
-61
lines changed

13 files changed

+12
-61
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
// Install features. Type 'feature' in the VS Code command palette for a full list.
1919
"features": {
20-
"git-lfs": "latest",
2120
"sshd": "latest"
2221
},
2322

@@ -42,7 +41,7 @@
4241
},
4342

4443
// Use 'postCreateCommand' to run commands after the container is created.
45-
"postCreateCommand": "git lfs pull && npm ci",
44+
"postCreateCommand": "npm ci",
4645

4746
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
4847
"remoteUser": "node"

.github/actions-scripts/enterprise-server-issue-templates/release-issue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ This file should be automatically updated, but you can also run `script/update-e
101101
102102
### 🚢 🛳️ 🚢 Shipping the release branch
103103
104-
- [ ] The megabranch creator should push the search index LFS objects for the public `github/docs` repo. The LFS objects were already pushed for the internal repo after the `sync-english-index-for-<PLAN@RELEASE>` was added to the megabranch. To push the LFS objects to the public repo:
104+
- [ ] Sync the search indices for the new release:
105105
1. First navigate to the [sync search indices workflow](https://github.com/github/docs-internal/actions/workflows/sync-search-indices.yml).
106106
2. Then, to run the workflow with parameters, click on `Run workflow` button.
107107
3. A modal will pop up where you will set the following inputs:

.github/workflows/azure-preview-env-deploy.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ jobs:
9191
with:
9292
ref: 'main'
9393
persist-credentials: 'false'
94-
lfs: 'true'
9594

9695
- if: ${{ env.IS_INTERNAL_BUILD == 'true' }}
9796
name: Check out PR code
@@ -100,10 +99,6 @@ jobs:
10099
ref: ${{ env.COMMIT_REF }}
101100
# To prevent issues with cloning early access content later
102101
persist-credentials: 'false'
103-
lfs: 'true'
104-
105-
- name: Check out LFS objects
106-
run: git lfs checkout
107102

108103
- name: Get preview app info
109104
env:

.github/workflows/azure-staging-build-deploy.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ jobs:
6565
ref: ${{ env.COMMIT_REF }}
6666
# To prevent issues with cloning early access content later
6767
persist-credentials: 'false'
68-
lfs: 'true'
69-
70-
- name: Check out LFS objects
71-
run: git lfs checkout
7268

7369
- name: 'Set env vars'
7470
run: |

.github/workflows/browser-test.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ jobs:
5050

5151
- name: Checkout
5252
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
53-
with:
54-
lfs: true
55-
56-
- name: Checkout LFS objects
57-
run: git lfs checkout
5853

5954
- name: Setup Node
6055
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516

.github/workflows/main-preview-docker-cache.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@ jobs:
4949
with:
5050
# To prevent issues with cloning early access content later
5151
persist-credentials: 'false'
52-
lfs: 'true'
53-
54-
- name: Check out LFS objects
55-
run: git lfs checkout
5652

5753
- if: ${{ env.ENABLE_EARLY_ACCESS }}
5854
name: Clone docs-early-access

.github/workflows/repo-sync.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,10 @@ jobs:
100100
- name: Check out repo
101101
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
102102

103-
# Set up npm and run npm ci to run husky to get githooks for LFS
103+
# Set up npm and run npm ci to get custom husky githooks error
104+
# messages if they exist. We could also remove these two steps
105+
# because currently we have no hooks with customer error messages.
106+
# See pull #32064 where they were removed.
104107
- name: Setup node
105108
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
106109
with:

.github/workflows/test.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,6 @@ jobs:
6666
# Even if if doesn't do anything
6767
- name: Check out repo
6868
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
69-
with:
70-
# Not all test suites need the LFS files. So instead, we opt to
71-
# NOT clone them initially and instead, include them manually
72-
# only for the test groups that we know need the files.
73-
lfs: ${{ matrix.test-group == 'content' }}
74-
# Enables cloning the Early Access repo later with the relevant PAT
75-
# persist-credentials: 'false'
76-
# ->> Do we really need this? actions/checkout doesn't use it for the nested example:
77-
# https://github.com/actions/checkout#checkout-multiple-repos-nested
7869

7970
- name: Setup node
8071
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
@@ -172,11 +163,6 @@ jobs:
172163
token: ${{ secrets.DOCUBOT_REPO_PAT }}
173164
path: translations/ko-kr
174165

175-
# This is necessary when LFS files where cloned but does nothing
176-
# if actions/checkout was run with `lfs:false`.
177-
- name: Checkout LFS objects
178-
run: git lfs checkout
179-
180166
- name: Gather files changed
181167
env:
182168
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

CONTRIBUTING.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,19 +48,17 @@ For more information about using a codespace for working on GitHub documentation
4848

4949
#### Make changes locally
5050

51-
1. [Install Git LFS](https://docs.github.com/en/github/managing-large-files/versioning-large-files/installing-git-large-file-storage).
52-
53-
2. Fork the repository.
51+
1. Fork the repository.
5452
- Using GitHub Desktop:
5553
- [Getting started with GitHub Desktop](https://docs.github.com/en/desktop/installing-and-configuring-github-desktop/getting-started-with-github-desktop) will guide you through setting up Desktop.
5654
- Once Desktop is set up, you can use it to [fork the repo](https://docs.github.com/en/desktop/contributing-and-collaborating-using-github-desktop/cloning-and-forking-repositories-from-github-desktop)!
5755

5856
- Using the command line:
5957
- [Fork the repo](https://docs.github.com/en/github/getting-started-with-github/fork-a-repo#fork-an-example-repository) so that you can make your changes without affecting the original project until you're ready to merge them.
6058

61-
3. Install or update to **Node.js v16**. For more information, see [the development guide](contributing/development.md).
59+
2. Install or update to **Node.js v16**. For more information, see [the development guide](contributing/development.md).
6260

63-
4. Create a working branch and start with your changes!
61+
3. Create a working branch and start with your changes!
6462

6563
### Commit your update
6664

contributing/development.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@ It runs on macOS, Windows, and Linux environments.
1010

1111
You'll need Node.js version 16 to run the site. To install Node.js, [download the "LTS" installer from nodejs.org](https://nodejs.org). If you're using [`nodenv`](https://github.com/nodenv/nodenv), read the [`nodenv` docs](https://github.com/nodenv/nodenv#readme) for instructions on switching Node.js versions.
1212

13-
You'll want to [install Git LFS](https://docs.github.com/en/github/managing-large-files/versioning-large-files/installing-git-large-file-storage).
14-
15-
Once you've installed Node.js (which includes the popular `npm` package manager) and Git LFS, open Terminal and run the following:
13+
Once you've installed Node.js (which includes the popular `npm` package manager), open Terminal and run the following:
1614

1715
```sh
1816
git clone https://github.com/github/docs

0 commit comments

Comments
 (0)