Skip to content

Commit a999980

Browse files
aschackmullaschackmull
committed
Dataflow: Simplify diff-informed implementation and tweak flag name.
1 parent 2e6f34d commit a999980

File tree

68 files changed

+177
-401
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+177
-401
lines changed

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplLocal.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl5.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎go/ql/lib/semmle/go/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎go/ql/lib/semmle/go/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl5.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl6.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ module IntentRedirectionConfig implements DataFlow::ConfigSig {
1919
any(IntentRedirectionAdditionalTaintStep c).step(node1, node2)
2020
}
2121

22-
predicate filterForSourceOrSinkAlerts() { any() }
22+
predicate observeDiffInformedIncrementalMode() { any() }
2323
}
2424

2525
/** Tracks the flow of tainted Intents being used to start Android components. */

‎java/ql/lib/semmle/code/java/security/ExternallyControlledFormatStringQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module ExternallyControlledFormatStringConfig implements DataFlow::ConfigSig {
2424
node.getType() instanceof NumericType or node.getType() instanceof BooleanType
2525
}
2626

27-
predicate filterForSourceOrSinkAlerts() { any() }
27+
predicate observeDiffInformedIncrementalMode() { any() }
2828
}
2929

3030
/**

‎java/ql/lib/semmle/code/java/security/FragmentInjectionQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module FragmentInjectionTaintConfig implements DataFlow::ConfigSig {
1818
any(FragmentInjectionAdditionalTaintStep c).step(n1, n2)
1919
}
2020

21-
predicate filterForSourceOrSinkAlerts() { any() }
21+
predicate observeDiffInformedIncrementalMode() { any() }
2222
}
2323

2424
/**

‎java/ql/lib/semmle/code/java/security/GroovyInjectionQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module GroovyInjectionConfig implements DataFlow::ConfigSig {
1818
any(GroovyInjectionAdditionalTaintStep c).step(fromNode, toNode)
1919
}
2020

21-
predicate filterForSourceOrSinkAlerts() { any() }
21+
predicate observeDiffInformedIncrementalMode() { any() }
2222
}
2323

2424
/**

‎java/ql/lib/semmle/code/java/security/ImplicitPendingIntentsQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ module ImplicitPendingIntentStartConfig implements DataFlow::StateConfigSig {
4949
c instanceof DataFlow::ArrayContent
5050
}
5151

52-
predicate filterForSourceOrSinkAlerts() { any() }
52+
predicate observeDiffInformedIncrementalMode() { any() }
5353
}
5454

5555
module ImplicitPendingIntentStartFlow =

‎java/ql/lib/semmle/code/java/security/InsecureBeanValidationQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ module BeanValidationConfig implements DataFlow::ConfigSig {
5050

5151
predicate isSink(DataFlow::Node sink) { sink instanceof BeanValidationSink }
5252

53-
predicate filterForSourceOrSinkAlerts() { any() }
53+
predicate observeDiffInformedIncrementalMode() { any() }
5454
}
5555

5656
/** Tracks flow from user input to the argument of a method that builds constraint error messages. */

‎java/ql/lib/semmle/code/java/security/InsecureLdapAuthQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ module InsecureLdapUrlConfig implements DataFlow::ConfigSig {
2323
)
2424
}
2525

26-
predicate filterForSourceOrSinkAlerts() { any() }
26+
predicate observeDiffInformedIncrementalMode() { any() }
2727
}
2828

2929
module InsecureLdapUrlFlow = TaintTracking::Global<InsecureLdapUrlConfig>;

0 commit comments

Comments
 (0)