Skip to content

Commit 3a1e50d

Browse files
aschackmullcklin
aschackmull
authored and
cklin
committed
Dataflow: Simplify diff-informed implementation and tweak flag name.
1 parent ff78beb commit 3a1e50d

File tree

32 files changed

+142
-365
lines changed

32 files changed

+142
-365
lines changed

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplLocal.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImpl5.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎go/ql/lib/semmle/go/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎go/ql/lib/semmle/go/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl5.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImpl6.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl1.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl2.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl3.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

‎python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImpl4.qll

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -284,13 +284,7 @@ deprecated private module Config implements FullStateConfigSig {
284284

285285
predicate includeHiddenNodes() { any(Configuration config).includeHiddenNodes() }
286286

287-
predicate filterForSourceOrSinkAlerts() { none() }
288-
289-
predicate isFilteredSource(Node source, FlowState state) { isSource(source, state) }
290-
291-
predicate isFilteredSink(Node sink, FlowState state) { isSink(sink, state) }
292-
293-
predicate isFilteredSink(Node sink) { isSink(sink) }
287+
predicate observeDiffInformedIncrementalMode() { none() }
294288
}
295289

296290
deprecated private import Impl<Config> as I

0 commit comments

Comments
 (0)