Skip to content

Commit 1228080

Browse files
committed
Bulk generator: Specify 'language' in the config file.
1 parent fc165db commit 1228080

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

cpp/misc/bulk_generation_targets.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"strategy": "dca",
3+
"language": "cpp",
34
"targets": [
45
{ "name": "openssl", "with_summaries": true },
56
{ "name": "sqlite", "with_summaries": true }

misc/scripts/models-as-data/bulk_generate_mad.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def build_database(
196196
return database_dir
197197

198198

199-
def generate_models(language: str, config, project: Project, database_dir: str) -> None:
199+
def generate_models(config, project: Project, database_dir: str) -> None:
200200
"""
201201
Generate models for a project.
202202
@@ -206,6 +206,7 @@ def generate_models(language: str, config, project: Project, database_dir: str)
206206
database_dir: Path to the CodeQL database.
207207
"""
208208
name = project["name"]
209+
language = config["language"]
209210

210211
generator = mad.Generator(language)
211212
# Note: The argument parser converts with-sinks to with_sinks, etc.
@@ -402,7 +403,10 @@ def main(config, args) -> None:
402403
"""
403404

404405
projects = config["targets"]
405-
language = args.lang
406+
if not "language" in config:
407+
print("ERROR: 'language' key is missing in the configuration file.")
408+
sys.exit(1)
409+
language = config["language"]
406410

407411
# Create build directory if it doesn't exist
408412
if not os.path.exists(build_dir):
@@ -464,7 +468,7 @@ def main(config, args) -> None:
464468

465469
for project, database_dir in database_results:
466470
if database_dir is not None:
467-
generate_models(language, config, project, database_dir)
471+
generate_models(config, project, database_dir)
468472

469473

470474
if __name__ == "__main__":
@@ -484,9 +488,6 @@ def main(config, args) -> None:
484488
help="PAT token to grab DCA databases (the same as the one you use for DCA)",
485489
required=False,
486490
)
487-
parser.add_argument(
488-
"--lang", type=str, help="The language to generate models for", required=True
489-
)
490491
args = parser.parse_args()
491492

492493
# Load config file

rust/misc/bulk_generation_targets.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"strategy": "repo",
3+
"language": "rust",
34
"targets": [
45
{
56
"name": "libc",

0 commit comments

Comments
 (0)