Autobuild breaks with Go 1.18 code

[hairyhenderson]

Go 1.18 introduced generics, and projects which are starting to use generics will no longer work with Autobuild, which seems to be built with Go 1.17.

Here's an example of a workflow that fails due to this issue:

https://github.com/hairyhenderson/go-fsimpl/runs/6335289871?check_suite_focus=true

Notable log messages:

...
[2022-05-07 15:31:05] [build-stderr] 2022/05/07 15:31:05 Autobuilder was built with go1.17.9, environment has go1.17.9
...
[2022-05-07 15:31:52] [build-stderr] 2022/05/07 15:31:52 Error running go tooling: err: exit status 1: stderr: go build github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: build constraints exclude all Go files in /home/runner/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.4.0

I looked in the documentation for a way to force Autobuild to use Go 1.18, but couldn't find one - is there a workaround?

[hairyhenderson]

This seems related to github/codeql#9297

[aeisenberg]

Yes, go 1.18 support is still in progress.

[bcho]

Hey, any way to exclude a library in codeql-go ? I am seeing this issue too :(

[aeisenberg]

I'm not sure what you asking. All libraries required for building code will be required for creating the database. If you are able to change your build so that a library is not required, then you can exclude the library. But, this is something that you would need to do.

[bcho]

I mean excluding a library from the scanning, as it’s failed to build due to codeql-go doesn’t support go 1.18 yet.

[aeisenberg]

I still don't understand. Is this a library that your build is compiling? Or is this a library that your build is linking to? You will need to find a way to build the code that you want analyzed using go 1.17. If that is not possible, you will need to wait until 1.18 support is available.

[bcho]

I see, I am compiling with this library. I was thinking we could we a way to exclude it during the database build up phase. But it seems like impossible to do that. I will wait until 1.18 support. Do you happen to know the ETA?

[aeisenberg]

I can't make any promises on when it will be delivered, but I can say that it is actively being worked on. Please keep an eye on the releases of codeql.

[edoardopirovano]

I'm maybe in a better position to give you information on when this will be out (although this still isn't a promise, as things may go wrong and affect this timeline). Support for Go 1.18 is in the 2.9.2 release of CodeQL, which is currently undergoing testing and is due to be released early this week (possibly even later today if all goes smoothly).

We roll out new releases of CodeQL to all our users in a few stages. Initially, you would only get this release if you explicitly requested it, which is a bit awkward to do and I would not recommend as it will result in you not getting updates. Around 1-2 working days after a release is live, you will get it if you specify tools: latest in the parameters (the with: block) of the init step of your workflow, which opts you into getting bleeding edge releases (note that doing this adds a short time to your workflow, as the release has to be downloaded rather already being present on GitHub Actions runners). Otherwise, it will take around 2 weeks from the release date to have it on all GitHub Actions runners and therefore be the default release for everyone.

[bcho]

Thank you for the clear release timeline and progress, much appreciated.

[edoardopirovano]

Thank you for the clear release timeline and progress, much appreciated.

No problem! Hopefully everything goes smoothly for you once you get the new release. If not, @owen-mc will be interested in hearing about that (tagging now so he gets updates to further replies here).

[bcho]

Hey, it's July now, but I am still seeing the same issue in my build. Any updates from your end? @edoardopirovano

[edoardopirovano]

Hey, it's July now, but I am still seeing the same issue in my build. Any updates from your end? @edoardopirovano

Strange. We definitely rolled out Go 1.18 support back in late May. Do you have a link to your workflow so I can pass this along to the Go team to investigate?

[bcho]

Hey, it's July now, but I am still seeing the same issue in my build. Any updates from your end? @edoardopirovano

Strange. We definitely rolled out Go 1.18 support back in late May. Do you have a link to your workflow so I can pass this along to the Go team to investigate?

My build is from a private repo, how can I pass the link to you? Or maybe I can try create a public repo to repro the same issue

[bcho]

@edoardopirovano here is a build from a minimal repro: https://github.com/bcho/codeql-go-118/runs/7336675767?check_suite_focus=true

  [2022-07-14 08:55:16] [build-stderr] 2022/07/14 08:55:16 Error running go tooling: err: exit status 1: stderr: go build github.com/Azure/azure-sdk-for-go/sdk/storage/azblob: build constraints exclude all Go files in /home/runner/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.4.1
  [2022-07-14 08:55:16] [build-stderr] 2022/07/14 08:55:16 Extraction failed: exit status 1
  Error: 7-14 08:55:16] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/opt/hostedtoolcache/CodeQL/0.0.0-20220623/x64/codeql/tools/linux64/preload_tracer, /opt/hostedtoolcache/CodeQL/0.0.0-20220623/x64/codeql/go/tools/autobuild.sh])
  A fatal error occurred: Exit status 1 from command: [/opt/hostedtoolcache/CodeQL/0.0.0-20220623/x64/codeql/go/tools/autobuild.sh]
  Error: The process '/opt/hostedtoolcache/CodeQL/0.0.0-20220623/x64/codeql/codeql' failed with exit code 2
  Error: The process '/opt/hostedtoolcache/CodeQL/0.0.0-20220623/x64/codeql/codeql' failed with exit code 2
      at toolrunnerErrorCatcher (/home/runner/work/_actions/github/codeql-action/v2/lib/toolrunner-error-catcher.js:86:19)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async Object.extractScannedLanguage (/home/runner/work/_actions/github/codeql-action/v2/lib/codeql.js:548:13)
      at async createdDBForScannedLanguages (/home/runner/work/_actions/github/codeql-action/v2/lib/analyze.js:82:13)
      at async finalizeDatabaseCreation (/home/runner/work/_actions/github/codeql-action/v2/lib/analyze.js:101:5)
      at async runFinalize (/home/runner/work/_actions/github/codeql-action/v2/lib/analyze.js:249:5)
      at async run (/home/runner/work/_actions/github/codeql-action/v2/lib/analyze-action.js:83:9)
      at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/analyze-action.js:221:9)

Repo: https://github.com/bcho/codeql-go-118