From 1b9049b6b1060c96be377f3b0eaeaa6a9fc819f8 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Thu, 16 Nov 2017 17:59:12 +0000 Subject: [PATCH 1/3] Add junk that NuGet/Visual Studio insists on adding Adding it now so we're not fighting VS everytime we update a package. --- src/DesignTimeStyleHelper/App.config | 8 ++++++++ src/GitHub.App/GitHub.App.csproj | 2 ++ .../GitHub.Exports.Reactive.csproj | 6 +++++- src/GitHub.Exports/GitHub.Exports.csproj | 6 +++++- src/GitHub.StartPage/app.config | 4 ++++ .../GitHub.TeamFoundation.14.csproj | 2 ++ .../GitHub.TeamFoundation.15.csproj | 2 ++ src/GitHub.VisualStudio/GitHub.VisualStudio.csproj | 2 ++ src/GitHub.VisualStudio/app.config | 8 ++++++++ test/UnitTests/app.config | 4 ++++ 10 files changed, 42 insertions(+), 2 deletions(-) diff --git a/src/DesignTimeStyleHelper/App.config b/src/DesignTimeStyleHelper/App.config index ceb380f285..557a097f84 100644 --- a/src/DesignTimeStyleHelper/App.config +++ b/src/DesignTimeStyleHelper/App.config @@ -45,6 +45,14 @@ + + + + + + + + diff --git a/src/GitHub.App/GitHub.App.csproj b/src/GitHub.App/GitHub.App.csproj index cd65e75f6b..afda3b9ed3 100644 --- a/src/GitHub.App/GitHub.App.csproj +++ b/src/GitHub.App/GitHub.App.csproj @@ -16,6 +16,8 @@ ..\common\GitHubVS.ruleset true true + + true diff --git a/src/GitHub.Exports.Reactive/GitHub.Exports.Reactive.csproj b/src/GitHub.Exports.Reactive/GitHub.Exports.Reactive.csproj index 4aa4aa7710..4c270a7bf1 100644 --- a/src/GitHub.Exports.Reactive/GitHub.Exports.Reactive.csproj +++ b/src/GitHub.Exports.Reactive/GitHub.Exports.Reactive.csproj @@ -15,6 +15,8 @@ ..\common\GitHubVS.ruleset true true + + true @@ -171,7 +173,9 @@ - + + Designer + diff --git a/src/GitHub.Exports/GitHub.Exports.csproj b/src/GitHub.Exports/GitHub.Exports.csproj index 400ebe23b8..d55240525b 100644 --- a/src/GitHub.Exports/GitHub.Exports.csproj +++ b/src/GitHub.Exports/GitHub.Exports.csproj @@ -15,6 +15,8 @@ ..\common\GitHubVS.ruleset true true + + true @@ -210,7 +212,9 @@ Properties\SolutionInfo.cs - + + Designer + diff --git a/src/GitHub.StartPage/app.config b/src/GitHub.StartPage/app.config index 4ce1b41e08..13c469edf2 100644 --- a/src/GitHub.StartPage/app.config +++ b/src/GitHub.StartPage/app.config @@ -26,6 +26,10 @@ + + + + diff --git a/src/GitHub.TeamFoundation.14/GitHub.TeamFoundation.14.csproj b/src/GitHub.TeamFoundation.14/GitHub.TeamFoundation.14.csproj index 49fa3f4f42..821246ef44 100644 --- a/src/GitHub.TeamFoundation.14/GitHub.TeamFoundation.14.csproj +++ b/src/GitHub.TeamFoundation.14/GitHub.TeamFoundation.14.csproj @@ -17,6 +17,8 @@ ..\common\GitHubVS.ruleset true true + + true diff --git a/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj b/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj index dec640da3c..cb5f8bc490 100644 --- a/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj +++ b/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj @@ -17,6 +17,8 @@ ..\common\GitHubVS.ruleset true true + + true diff --git a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj index 12cf3e14b2..345482bd61 100644 --- a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj +++ b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj @@ -12,6 +12,8 @@ v3 false GitHub\GitHub + + diff --git a/src/GitHub.VisualStudio/app.config b/src/GitHub.VisualStudio/app.config index 4a5857ad2e..fc2812b791 100644 --- a/src/GitHub.VisualStudio/app.config +++ b/src/GitHub.VisualStudio/app.config @@ -38,6 +38,14 @@ + + + + + + + + \ No newline at end of file diff --git a/test/UnitTests/app.config b/test/UnitTests/app.config index 0aa08daa21..410da07cd4 100644 --- a/test/UnitTests/app.config +++ b/test/UnitTests/app.config @@ -34,6 +34,10 @@ + + + + From 2e27af4215af943a9abb4b6d250de408a266053e Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Fri, 17 Nov 2017 15:08:41 +0000 Subject: [PATCH 2/3] Stop NuGet from creating binding redirects when package is installed https://docs.microsoft.com/en-us/nuget/schema/nuget-config-file#bindingredirects-section --- nuget.config | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nuget.config b/nuget.config index ac070021ef..f9e15995d3 100644 --- a/nuget.config +++ b/nuget.config @@ -7,4 +7,7 @@ - \ No newline at end of file + + + + From e488e051cfe3a0e16f673496727c23a4483aa674 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Fri, 17 Nov 2017 15:25:43 +0000 Subject: [PATCH 3/3] Remove unused App.config files from solution App.config files don't do anything for extensions. --- src/GitHub.App/GitHub.App.csproj | 3 -- src/GitHub.App/app.config | 19 ------- .../GitHub.InlineReviews.csproj | 3 -- src/GitHub.InlineReviews/app.config | 19 ------- src/GitHub.StartPage/GitHub.StartPage.csproj | 1 - src/GitHub.StartPage/app.config | 35 ------------- .../GitHub.TeamFoundation.15.csproj | 3 -- src/GitHub.TeamFoundation.15/app.config | 39 -------------- .../GitHub.VisualStudio.csproj | 3 -- src/GitHub.VisualStudio/app.config | 51 ------------------- .../GitHub.InlineReviews.UnitTests.csproj | 3 -- .../GitHub.InlineReviews.UnitTests/app.config | 27 ---------- test/UnitTests/UnitTests.csproj | 3 -- test/UnitTests/app.config | 43 ---------------- 14 files changed, 252 deletions(-) delete mode 100644 src/GitHub.App/app.config delete mode 100644 src/GitHub.InlineReviews/app.config delete mode 100644 src/GitHub.StartPage/app.config delete mode 100644 src/GitHub.TeamFoundation.15/app.config delete mode 100644 src/GitHub.VisualStudio/app.config delete mode 100644 test/GitHub.InlineReviews.UnitTests/app.config delete mode 100644 test/UnitTests/app.config diff --git a/src/GitHub.App/GitHub.App.csproj b/src/GitHub.App/GitHub.App.csproj index afda3b9ed3..c8fd534300 100644 --- a/src/GitHub.App/GitHub.App.csproj +++ b/src/GitHub.App/GitHub.App.csproj @@ -239,9 +239,6 @@ - - Designer - Designer diff --git a/src/GitHub.App/app.config b/src/GitHub.App/app.config deleted file mode 100644 index 074e2f8475..0000000000 --- a/src/GitHub.App/app.config +++ /dev/null @@ -1,19 +0,0 @@ - - - - - - - - - - - - - - - - - - - diff --git a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj index e62e708cdd..d7e0f3d91f 100644 --- a/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj +++ b/src/GitHub.InlineReviews/GitHub.InlineReviews.csproj @@ -164,9 +164,6 @@ - - Designer - Designer diff --git a/src/GitHub.InlineReviews/app.config b/src/GitHub.InlineReviews/app.config deleted file mode 100644 index 946427e252..0000000000 --- a/src/GitHub.InlineReviews/app.config +++ /dev/null @@ -1,19 +0,0 @@ - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/GitHub.StartPage/GitHub.StartPage.csproj b/src/GitHub.StartPage/GitHub.StartPage.csproj index 8cfc175579..f5be5ec548 100644 --- a/src/GitHub.StartPage/GitHub.StartPage.csproj +++ b/src/GitHub.StartPage/GitHub.StartPage.csproj @@ -70,7 +70,6 @@ - Designer diff --git a/src/GitHub.StartPage/app.config b/src/GitHub.StartPage/app.config deleted file mode 100644 index 13c469edf2..0000000000 --- a/src/GitHub.StartPage/app.config +++ /dev/null @@ -1,35 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj b/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj index cb5f8bc490..30167006ac 100644 --- a/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj +++ b/src/GitHub.TeamFoundation.15/GitHub.TeamFoundation.15.csproj @@ -232,9 +232,6 @@ Properties\SolutionInfo.cs - - Designer - Designer diff --git a/src/GitHub.TeamFoundation.15/app.config b/src/GitHub.TeamFoundation.15/app.config deleted file mode 100644 index 4f5c9a02a7..0000000000 --- a/src/GitHub.TeamFoundation.15/app.config +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj index 345482bd61..00ffe9a7cd 100644 --- a/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj +++ b/src/GitHub.VisualStudio/GitHub.VisualStudio.csproj @@ -419,9 +419,6 @@ GitHub.VisualStudio.Settings PackageSettingsGen.cs - - Designer - Designer diff --git a/src/GitHub.VisualStudio/app.config b/src/GitHub.VisualStudio/app.config deleted file mode 100644 index fc2812b791..0000000000 --- a/src/GitHub.VisualStudio/app.config +++ /dev/null @@ -1,51 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/GitHub.InlineReviews.UnitTests/GitHub.InlineReviews.UnitTests.csproj b/test/GitHub.InlineReviews.UnitTests/GitHub.InlineReviews.UnitTests.csproj index a22d1f9db3..1cc2c42efb 100644 --- a/test/GitHub.InlineReviews.UnitTests/GitHub.InlineReviews.UnitTests.csproj +++ b/test/GitHub.InlineReviews.UnitTests/GitHub.InlineReviews.UnitTests.csproj @@ -149,9 +149,6 @@ - - Designer - Designer diff --git a/test/GitHub.InlineReviews.UnitTests/app.config b/test/GitHub.InlineReviews.UnitTests/app.config deleted file mode 100644 index 61e184303d..0000000000 --- a/test/GitHub.InlineReviews.UnitTests/app.config +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/test/UnitTests/UnitTests.csproj b/test/UnitTests/UnitTests.csproj index 4a6deb2469..7a8d397e06 100644 --- a/test/UnitTests/UnitTests.csproj +++ b/test/UnitTests/UnitTests.csproj @@ -365,9 +365,6 @@ - - Designer - Designer diff --git a/test/UnitTests/app.config b/test/UnitTests/app.config deleted file mode 100644 index 410da07cd4..0000000000 --- a/test/UnitTests/app.config +++ /dev/null @@ -1,43 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -