You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
If you debug into PullRequestReviewCommentViewModel.DoOpen and click on one of the comments, you can see that it's trying to get the file at the branch's HEAD commit, but at this commit the comment is outdated. So looks like we need to check the thread model and if it's outdated use the OriginalCommitSha.
Also PullRequestSessionService.BuildCommentThreads appears to filter out outdated threads, so that check probably needs to be removed (at least if building comments for the non-HEAD commit?)
Versions
What happened
I opened a pull request review and clicked on link to an outdated comment. Nothing happened.
Steps to Reproduce
Steps to reproduce the behavior:
github/VisualStudio
pull request 2241 on GitHub paneReviewers > jcansdale
Outdated comments
Expected behavior
File diff appears with selected comment.
If this can't be made to work, maybe we could open the comment on dotcom?
Screenshots
Research
The issue appears to be that that the
PullRequestSessionFile
doesn't have any associatedInlineCommentThreads
.The text was updated successfully, but these errors were encountered: