Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Links to outdated comments in pull request reviews don't work #2247

Closed
jcansdale opened this issue Feb 27, 2019 · 1 comment · Fixed by #2249
Closed

Links to outdated comments in pull request reviews don't work #2247

jcansdale opened this issue Feb 27, 2019 · 1 comment · Fixed by #2249
Labels

Comments

@jcansdale
Copy link
Collaborator

jcansdale commented Feb 27, 2019

Versions

  • GitHub Extension for Visual Studio version: 2.8.0
  • Visual Studio version: All

What happened

I opened a pull request review and clicked on link to an outdated comment. Nothing happened.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open github/VisualStudio pull request 2241 on GitHub pane
  2. Click on Reviewers > jcansdale
  3. Expand Outdated comments
  4. Click on one of the outdated comment links
  5. Nothing happens

Expected behavior

File diff appears with selected comment.

If this can't be made to work, maybe we could open the comment on dotcom?

Screenshots

image

Research

The issue appears to be that that the PullRequestSessionFile doesn't have any associated InlineCommentThreads.

image

@jcansdale jcansdale added the bug label Feb 27, 2019
@grokys
Copy link
Contributor

grokys commented Feb 28, 2019

If you debug into PullRequestReviewCommentViewModel.DoOpen and click on one of the comments, you can see that it's trying to get the file at the branch's HEAD commit, but at this commit the comment is outdated. So looks like we need to check the thread model and if it's outdated use the OriginalCommitSha.

Also PullRequestSessionService.BuildCommentThreads appears to filter out outdated threads, so that check probably needs to be removed (at least if building comments for the non-HEAD commit?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants