Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit c7ba7d6

Browse files
DetailsUrl can be null
1 parent 8fb18b4 commit c7ba7d6

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public static IEnumerable<IPullRequestCheckViewModel> Build(IViewViewModelFactor
4848
pullRequestCheckViewModel.Title = statusModel.Context;
4949
pullRequestCheckViewModel.Description = statusModel.Description;
5050
pullRequestCheckViewModel.Status = checkStatus;
51-
pullRequestCheckViewModel.DetailsUrl = new Uri(statusModel.TargetUrl);
51+
pullRequestCheckViewModel.DetailsUrl = statusModel.TargetUrl != null ? new Uri(statusModel.TargetUrl) : null;
5252
pullRequestCheckViewModel.AvatarUrl = statusModel.AvatarUrl ?? DefaultAvatar;
5353
pullRequestCheckViewModel.Avatar = statusModel.AvatarUrl != null
5454
? new BitmapImage(new Uri(statusModel.AvatarUrl))

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@
5252
Visibility="{Binding HasAnnotations, Converter={ghfvs:BooleanToVisibilityConverter}}"
5353
Margin="0 0 0 0" Icon="file_code" Foreground="Black" />
5454
</Label>
55-
<Label Grid.Column="4" HorizontalAlignment="Right">
56-
<Hyperlink ToolTip="{Binding DetailsUrl}" Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
55+
<Label Grid.Column="4" HorizontalAlignment="Right"
56+
Visibility="{Binding DetailsUrl, Converter={ghfvs:NullToVisibilityConverter}}">
57+
<Hyperlink ToolTip="{Binding DetailsUrl}" Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
5758
</Label>
5859
</Grid>
5960
</local:GenericPullRequestCheckView>

0 commit comments

Comments
 (0)