This repository was archived by the owner on Jun 21, 2023. It is now read-only.
File tree 2 files changed +1
-21
lines changed
src/GitHub.InlineReviews/ViewModels
2 files changed +1
-21
lines changed Original file line number Diff line number Diff line change @@ -9,10 +9,9 @@ namespace GitHub.InlineReviews.ViewModels
9
9
/// <summary>
10
10
/// Base view model for a thread of comments.
11
11
/// </summary>
12
- public abstract class CommentThreadViewModel : ReactiveObject , ICommentThreadViewModel , IDisposable
12
+ public abstract class CommentThreadViewModel : ReactiveObject , ICommentThreadViewModel
13
13
{
14
14
ReactiveCommand < ICommentModel > postComment ;
15
- IDisposable placeholderSubscription ;
16
15
17
16
/// <summary>
18
17
/// Intializes a new instance of the <see cref="CommentThreadViewModel"/> class.
@@ -48,21 +47,7 @@ public ReactiveCommand<ICommentModel> PostComment
48
47
/// <inheritdoc/>
49
48
public IAccount CurrentUser { get ; }
50
49
51
- public void Dispose ( )
52
- {
53
- Dispose ( true ) ;
54
- GC . SuppressFinalize ( this ) ;
55
- }
56
-
57
50
/// <inheritdoc/>
58
51
public abstract Uri GetCommentUrl ( int id ) ;
59
-
60
- protected virtual void Dispose ( bool disposing )
61
- {
62
- if ( disposing )
63
- {
64
- placeholderSubscription ? . Dispose ( ) ;
65
- }
66
- }
67
52
}
68
53
}
Original file line number Diff line number Diff line change 1
1
using System ;
2
2
using System . Linq ;
3
- using System . Reactive ;
4
3
using System . Reactive . Linq ;
5
- using System . Reactive . Subjects ;
6
4
using System . Threading . Tasks ;
7
- using GitHub . Api ;
8
5
using GitHub . Extensions ;
9
6
using GitHub . Models ;
10
7
using GitHub . Services ;
@@ -17,7 +14,6 @@ namespace GitHub.InlineReviews.ViewModels
17
14
/// </summary>
18
15
public class NewInlineCommentThreadViewModel : CommentThreadViewModel
19
16
{
20
- readonly Subject < Unit > finished = new Subject < Unit > ( ) ;
21
17
bool needsPush ;
22
18
23
19
/// <summary>
@@ -116,7 +112,6 @@ async Task<ICommentModel> DoPostComment(object parameter)
116
112
File . RelativePath . Replace ( "\\ " , "/" ) ,
117
113
diffPosition . DiffLineNumber ) ;
118
114
119
- finished . OnNext ( Unit . Default ) ;
120
115
return model ;
121
116
}
122
117
}
You can’t perform that action at this time.
0 commit comments