Skip to content

Commit bfbfc9a

Browse files
jrngitster
authored andcommitted
send-email: Net::SMTP::starttls was introduced in v2.34
We cannot rely on the starttls method being present in Net::SMTP until c274b798e6881a941d941808c6d89966975cb8c8 (Merge branch 'ipv6_ssl' of https://github.com/noxxi/perl-libnet into noxxi-ipv6_ssl, 2014-06-02), which set the module version to 2.34. This version was first shipped as part of perl in v5.21.5~169 (Update libnet to CPAN version 3.01, 2014-10-10). Noticed on an Ubuntu system with perl 5.18.2-2ubuntu1.1, which provides Net::SMTP version 2.31. The error message is Can't locate object method "starttls" via package "Net::SMTP" at /usr/lib/git-core/git-send-email line 1410. Reported-by: Brandon Williams <[email protected]> Reported-and-tested-by: Eric Biggers <[email protected]> Signed-off-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0ead000 commit bfbfc9a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-send-email.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1354,7 +1354,7 @@ sub send_message {
13541354
}
13551355

13561356
require Net::SMTP;
1357-
my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("1.28");
1357+
my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("2.34");
13581358
$smtp_domain ||= maildomain();
13591359

13601360
if ($smtp_encryption eq 'ssl') {

0 commit comments

Comments
 (0)