Skip to content

Commit 99a5328

Browse files
committed
ci: stop linking built-ins to the dashed versions
Originally, all of Git's subcommands were implemented in their own executable/script, using the naming scheme `git-<command-name>`. When more and more functionality was turned into built-in commands (i.e. the `git` executable could run them without spawning a separate process), for backwards-compatibility, we hard-link the `git` executable to `git-<built-in>` for every built-in. This backwards-compatibility was needed to support scripts that called the dashed form, even if we deprecated that a _long_ time ago. For that reason, we just introduced a Makefile knob to skip linking them. To make sure that this keeps working, teach the CI (and PR) builds to skip generating those hard-links. This is actually not such a big change: e4597aa (run test suite without dashed git-commands in PATH, 2009-12-02) made sure that our test suite does not require dashed commands. With this Makefile knob, the commitment is just a little stronger (running tests with `--with-dashes` would _still_ not see the dashed form of the built-ins). There is a subtle change in behavior with this patch, though: as we no longer even _build_ the dashed executables, running the test suite would fail if any of Git's scripted commands (e.g. `git-request-pull`) still This would have succeeded previously (and would have been unintentional, of course) because `bin-wrappers/git` sets `GIT_EXEC_PATH` to the top-level directory (which would still have contained, say, `git-rev-parse`). Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 52deafd commit 99a5328

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ci/run-build-and-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ windows*) cmd //c mklink //j t\\.prove "$(cygpath -aw "$cache_dir/.prove")";;
1010
*) ln -s "$cache_dir/.prove" t/.prove;;
1111
esac
1212

13-
make
13+
make SKIP_DASHED_BUILT_INS=YesPlease
1414
case "$jobname" in
1515
linux-gcc)
1616
make test

0 commit comments

Comments
 (0)