Skip to content

Commit 814291c

Browse files
szedergitster
authored andcommitted
t5510-fetch: fix negated 'test_i18ngrep' invocation
The test '--no-show-forced-updates' in 't5510-fetch.sh' added in cdbd70c (fetch: add --[no-]show-forced-updates argument, 2019-06-18) runs '! test_i18ngrep ...'. This is wrong, because when running the test with GIT_TEST_GETTEXT_POISON=true, then 'test_i18ngrep' is basically a noop and always returns with success, the leading ! turns that into a failure, which then fails the test. Use 'test_i18ngrep ! ...' instead. This went unnoticed by our GETTEXT_POISON CI builds, because those builds don't run this test case: in those builds we don't install Apache, and this test comes after 't5510' sources 'lib-httpd.sh', which, consequently, skips all the remaining tests, including this one. Signed-off-by: SZEDER Gábor <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 026dd73 commit 814291c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t5510-fetch.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,7 @@ test_expect_success '--no-show-forced-updates' '
997997
(
998998
cd no-forced-update-clone &&
999999
git fetch --no-show-forced-updates origin 2>output &&
1000-
! test_i18ngrep "(forced update)" output
1000+
test_i18ngrep ! "(forced update)" output
10011001
)
10021002
'
10031003

0 commit comments

Comments
 (0)