Skip to content

Commit 03ef60b

Browse files
slavicaDjgitster
authored andcommitted
built-in add -i: use color in the main loop
The error messages as well as the unique prefixes are colored in `git add -i` by default; We need to do the same in the built-in version. Signed-off-by: Slavica Đukić <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6f26b71 commit 03ef60b

File tree

1 file changed

+29
-6
lines changed

1 file changed

+29
-6
lines changed

add-interactive.c

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ struct add_i_state {
1212
int use_color;
1313
char header_color[COLOR_MAXLEN];
1414
char help_color[COLOR_MAXLEN];
15+
char prompt_color[COLOR_MAXLEN];
16+
char error_color[COLOR_MAXLEN];
17+
char reset_color[COLOR_MAXLEN];
1518
};
1619

1720
static void init_color(struct repository *r, struct add_i_state *s,
@@ -45,6 +48,9 @@ static void init_add_i_state(struct add_i_state *s, struct repository *r)
4548

4649
init_color(r, s, "header", s->header_color, GIT_COLOR_BOLD);
4750
init_color(r, s, "help", s->help_color, GIT_COLOR_BOLD_RED);
51+
init_color(r, s, "prompt", s->prompt_color, GIT_COLOR_BOLD_BLUE);
52+
init_color(r, s, "error", s->error_color, GIT_COLOR_BOLD_RED);
53+
init_color(r, s, "reset", s->reset_color, GIT_COLOR_RESET);
4854
}
4955

5056
/*
@@ -240,7 +246,8 @@ static ssize_t list_and_choose(struct add_i_state *s,
240246

241247
list(s, &items->items, &opts->list_opts);
242248

243-
printf("%s%s", opts->prompt, "> ");
249+
color_fprintf(stdout, s->prompt_color, "%s", opts->prompt);
250+
fputs("> ", stdout);
244251
fflush(stdout);
245252

246253
if (strbuf_getline(&input, stdin) == EOF) {
@@ -281,7 +288,8 @@ static ssize_t list_and_choose(struct add_i_state *s,
281288
index = find_unique(p, items);
282289

283290
if (index < 0 || index >= items->items.nr)
284-
printf(_("Huh (%s)?\n"), p);
291+
color_fprintf_ln(stdout, s->error_color,
292+
_("Huh (%s)?"), p);
285293
else {
286294
res = index;
287295
break;
@@ -507,18 +515,23 @@ struct command_item {
507515
command_t command;
508516
};
509517

518+
struct print_command_item_data {
519+
const char *color, *reset;
520+
};
521+
510522
static void print_command_item(int i, struct string_list_item *item,
511523
void *print_command_item_data)
512524
{
525+
struct print_command_item_data *d = print_command_item_data;
513526
struct command_item *util = item->util;
514527

515528
if (!util->prefix_length ||
516529
!is_valid_prefix(item->string, util->prefix_length))
517530
printf(" %2d: %s", i + 1, item->string);
518531
else
519-
printf(" %2d: [%.*s]%s", i + 1,
520-
(int)util->prefix_length, item->string,
521-
item->string + util->prefix_length);
532+
printf(" %2d: %s%.*s%s%s", i + 1,
533+
d->color, (int)util->prefix_length, item->string,
534+
d->reset, item->string + util->prefix_length);
522535
}
523536

524537
static void command_prompt_help(struct add_i_state *s)
@@ -536,8 +549,9 @@ static void command_prompt_help(struct add_i_state *s)
536549
int run_add_i(struct repository *r, const struct pathspec *ps)
537550
{
538551
struct add_i_state s = { NULL };
552+
struct print_command_item_data data = { "[", "]" };
539553
struct list_and_choose_options main_loop_opts = {
540-
{ 4, N_("*** Commands ***"), print_command_item, NULL },
554+
{ 4, N_("*** Commands ***"), print_command_item, &data },
541555
N_("What now"), command_prompt_help
542556
};
543557
struct {
@@ -568,6 +582,15 @@ int run_add_i(struct repository *r, const struct pathspec *ps)
568582

569583
init_add_i_state(&s, r);
570584

585+
/*
586+
* When color was asked for, use the prompt color for
587+
* highlighting, otherwise use square brackets.
588+
*/
589+
if (s.use_color) {
590+
data.color = s.prompt_color;
591+
data.reset = s.reset_color;
592+
}
593+
571594
strbuf_addstr(&header, " ");
572595
strbuf_addf(&header, print_file_item_data.modified_fmt,
573596
_("staged"), _("unstaged"), _("path"));

0 commit comments

Comments
 (0)