Merge pull request #6 from epage/cleanup

epage · web-flow · commit ba890da39b6f · 2022-03-14T15:50:06.000-05:00
refactor(hooks): Simplify error checks
diff --git a/src/hooks.rs b/src/hooks.rs
@@ -134,10 +134,10 @@ impl Hooks {
         }
 
         match self.run_hook(repo, name, &args, Some(stdin.as_bytes()), &[]) {
-            Ok(code) if code != 0 => {
+            Ok(0) => {}
+            Ok(code) => {
                 log::trace!("Hook `{}` failed with code {}", name, code);
             }
-            Ok(_) => {}
             Err(err) => {
                 log::trace!("Hook `{}` failed with {}", name, err);
             }
@@ -223,10 +223,10 @@ impl Hooks {
         }
 
         match self.run_hook(repo, name, &args, Some(stdin.as_bytes()), &[]) {
-            Ok(code) if code != 0 => {
+            Ok(0) => {}
+            Ok(code) => {
                 log::trace!("Hook `{}` failed with code {}", name, code);
             }
-            Ok(_) => {}
             Err(err) => {
                 log::trace!("Hook `{}` failed with {}", name, err);
             }
@@ -254,10 +254,10 @@ impl Hooks {
         }
 
         match self.run_hook(repo, name, &args, Some(stdin.as_bytes()), &[]) {
-            Ok(code) if code != 0 => {
+            Ok(0) => {}
+            Ok(code) => {
                 log::trace!("Hook `{}` failed with code {}", name, code);
             }
-            Ok(_) => {}
             Err(err) => {
                 log::trace!("Hook `{}` failed with {}", name, err);
             }

Original file line number	Diff line number	Diff line change
`@@ -134,10 +134,10 @@ impl Hooks {`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`match self.run_hook(repo, name, &args, Some(stdin.as_bytes()), &[]) {`
`137`		`- Ok(code) if code != 0 => {`
	`137`	`+ Ok(0) => {}`
	`138`	`+ Ok(code) => {`
`138`	`139`	log::trace!("Hook `{}` failed with code {}", name, code);
`139`	`140`	`}`
`140`		`- Ok(_) => {}`
`141`	`141`	`Err(err) => {`
`142`	`142`	log::trace!("Hook `{}` failed with {}", name, err);
`143`	`143`	`}`
`@@ -223,10 +223,10 @@ impl Hooks {`
`223`	`223`	`}`
`224`	`224`
`225`	`225`	`match self.run_hook(repo, name, &args, Some(stdin.as_bytes()), &[]) {`
`226`		`- Ok(code) if code != 0 => {`
	`226`	`+ Ok(0) => {}`
	`227`	`+ Ok(code) => {`
`227`	`228`	log::trace!("Hook `{}` failed with code {}", name, code);
`228`	`229`	`}`
`229`		`- Ok(_) => {}`
`230`	`230`	`Err(err) => {`
`231`	`231`	log::trace!("Hook `{}` failed with {}", name, err);
`232`	`232`	`}`
`@@ -254,10 +254,10 @@ impl Hooks {`
`254`	`254`	`}`
`255`	`255`
`256`	`256`	`match self.run_hook(repo, name, &args, Some(stdin.as_bytes()), &[]) {`
`257`		`- Ok(code) if code != 0 => {`
	`257`	`+ Ok(0) => {}`
	`258`	`+ Ok(code) => {`
`258`	`259`	log::trace!("Hook `{}` failed with code {}", name, code);
`259`	`260`	`}`
`260`		`- Ok(_) => {}`
`261`	`261`	`Err(err) => {`
`262`	`262`	log::trace!("Hook `{}` failed with {}", name, err);
`263`	`263`	`}`