Skip to content

Commit febe51b

Browse files
committed
mingw: change core.fsyncObjectFiles = 1 by default
From the documentation of said setting: This boolean will enable fsync() when writing object files. This is a total waste of time and effort on a filesystem that orders data writes properly, but can be useful for filesystems that do not use journalling (traditional UNIX filesystems) or that only journal metadata and not file contents (OS X’s HFS+, or Linux ext3 with "data=writeback"). The most common file system on Windows (NTFS) does not guarantee that order, therefore a sudden loss of power (or any other event causing an unclean shutdown) would cause corrupt files (i.e. files filled with NULs). Therefore we need to change the default. Note that the documentation makes it sound as if this causes really bad performance. In reality, writing loose objects is something that is done only rarely, and only a handful of files at a time. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 081d23d commit febe51b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

compat/mingw.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3313,6 +3313,7 @@ int msc_startup(int argc, wchar_t **w_argv, wchar_t **w_env)
33133313
_CrtSetDbgFlag(_CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF);
33143314
#endif
33153315

3316+
fsync_object_files = 1;
33163317
maybe_redirect_std_handles();
33173318
adjust_symlink_flags();
33183319

@@ -3380,6 +3381,7 @@ void mingw_startup(void)
33803381
wchar_t **wenv, **wargv;
33813382
_startupinfo si;
33823383

3384+
fsync_object_files = 1;
33833385
maybe_redirect_std_handles();
33843386
adjust_symlink_flags();
33853387

0 commit comments

Comments
 (0)