Skip to content

Commit f4c6593

Browse files
kkhellerGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
Allow add -p and add -i with a large number of files
This fixes msysgit#182. Inspired by Pull Request 218 using code from @PhilipDavis. [jes: simplified code quite a bit] Signed-off-by: Kelly Heller <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent cae7dcf commit f4c6593

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

git-add--interactive.perl

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,24 @@ sub run_cmd_pipe {
160160
die "$^O does not support: @invalid\n" if @invalid;
161161
my @args = map { m/ /o ? "\"$_\"": $_ } @_;
162162
return qx{@args};
163+
} elsif (($^O eq 'MSWin32' || $^O eq 'msys') && (scalar @_ > 200) &&
164+
grep $_ eq '--', @_) {
165+
use File::Temp qw(tempfile);
166+
my ($fhargs, $filename) =
167+
tempfile('git-args-XXXXXX', UNLINK => 1);
168+
169+
my $cmd = 'cat '.$filename.' | xargs -0 -s 20000 ';
170+
while ($_[0] ne '--') {
171+
$cmd = $cmd . shift(@_) . ' ';
172+
}
173+
174+
shift(@_);
175+
print $fhargs join("\0", @_);
176+
close($fhargs);
177+
178+
my $fh = undef;
179+
open($fh, '-|', $cmd) or die;
180+
return <$fh>;
163181
} else {
164182
my $fh = undef;
165183
open($fh, '-|', @_) or die;

0 commit comments

Comments
 (0)