Skip to content

Commit 7064474

Browse files
PhilipOakleydscho
authored andcommitted
hash-object: demonstrate a >4GB/LLP64 problem
On LLP64 systems, such as Windows, the size of `long`, `int`, etc. is only 32 bits (for backward compatibility). Git's use of `unsigned long` for file memory sizes in many places, rather than size_t, limits the handling of large files on LLP64 systems (commonly given as `>4GB`). Provide a minimum test for handling a >4GB file. The `hash-object` command, with the `--literally` and without `-w` option avoids writing the object, either loose or packed. This avoids the code paths hitting the `bigFileThreshold` config test code, the zlib code, and the pack code. Subsequent patches will walk the test's call chain, converting types to `size_t` (which is larger in LLP64 data models) where appropriate. Signed-off-by: Philip Oakley <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 38993b5 commit 7064474

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

t/t1007-hash-object.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,9 @@ test_expect_success 'setup' '
4949
5050
example sha1:ddd3f836d3e3fbb7ae289aa9ae83536f76956399
5151
example sha256:b44fe1fe65589848253737db859bd490453510719d7424daab03daf0767b85ae
52+
53+
large5GB sha1:0be2be10a4c8764f32c4bf372a98edc731a4b204
54+
large5GB sha256:dc18ca621300c8d3cfa505a275641ebab00de189859e022a975056882d313e64
5255
EOF
5356
'
5457

@@ -265,4 +268,12 @@ test_expect_success '--stdin outside of repository (uses SHA-1)' '
265268
test_cmp expect actual
266269
'
267270

271+
test_expect_failure EXPENSIVE,SIZE_T_IS_64BIT,!LONG_IS_64BIT \
272+
'files over 4GB hash literally' '
273+
test-tool genzeros $((5*1024*1024*1024)) >big &&
274+
test_oid large5GB >expect &&
275+
git hash-object --stdin --literally <big >actual &&
276+
test_cmp expect actual
277+
'
278+
268279
test_done

0 commit comments

Comments
 (0)