Fix global repository field not being cleared (#4083)

dscho · Git for Windows Build Agent · commit 671db427bd56 · 2022-12-20T14:15:49.000Z
It is checked for w.r.t. global repository struct down in the callstack
in compatibility layer for MinGW before being assigned in the function
that `free()`'d it.
diff --git a/repository.c b/repository.c
@@ -46,7 +46,7 @@ static void repo_set_commondir(struct repository *repo,
 {
 	struct strbuf sb = STRBUF_INIT;
 
-	free(repo->commondir);
+	FREE_AND_NULL(repo->commondir);
 
 	if (commondir) {
 		repo->different_commondir = 1;

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ static void repo_set_commondir(struct repository *repo,`
`46`	`46`	`{`
`47`	`47`	`struct strbuf sb = STRBUF_INIT;`
`48`	`48`
`49`		`- free(repo->commondir);`
	`49`	`+ FREE_AND_NULL(repo->commondir);`
`50`	`50`
`51`	`51`	`if (commondir) {`
`52`	`52`	`repo->different_commondir = 1;`