Skip to content

Commit 5c0ebd2

Browse files
jeffhostetlerdscho
authored andcommitted
add: use preload-index and fscache for performance
Teach "add" to use preload-index and fscache features to improve performance on very large repositories. During an "add", a call is made to run_diff_files() which calls check_remove() for each index-entry. This calls lstat(). On Windows, the fscache code intercepts the lstat() calls and builds a private cache using the FindFirst/FindNext routines, which are much faster. Somewhat independent of this, is the preload-index code which distributes some of the start-up costs across multiple threads. We need to keep the call to read_cache() before parsing the pathspecs (and hence cannot use the pathspecs to limit any preload) because parse_pathspec() is using the index to determine whether a pathspec is, in fact, in a submodule. If we would not read the index first, parse_pathspec() would not error out on a path that is inside a submodule, and t7400-submodule-basic.sh would fail with not ok 47 - do not add files from a submodule We still want the nice preload performance boost, though, so we simply call read_cache_preload(&pathspecs) after parsing the pathspecs. Signed-off-by: Jeff Hostetler <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 5446709 commit 5c0ebd2

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

builtin/add.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,10 @@ int cmd_add(int argc, const char **argv, const char *prefix)
389389
PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE,
390390
prefix, argv);
391391

392+
enable_fscache(1);
393+
/* We do not really re-read the index, but update the up-to-date flags */
394+
preload_index(&the_index, &pathspec);
395+
392396
if (add_new_files) {
393397
int baselen;
394398

0 commit comments

Comments
 (0)