Skip to content

Commit 487cca6

Browse files
committed
fill_stat_cache_info(): prepare for an fsmonitor fix
We will need to pass down the `struct index_state` to `mark_fsmonitor_valid()` for an upcoming bug fix, and this here function calls that there function, so we need to extend the signature of `fill_stat_cache_info()` first. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent cf772c6 commit 487cca6

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

apply.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4320,7 +4320,7 @@ static int add_index_file(struct apply_state *state,
43204320
"created file '%s'"),
43214321
path);
43224322
}
4323-
fill_stat_cache_info(ce, &st);
4323+
fill_stat_cache_info(state->repo->index, ce, &st);
43244324
}
43254325
if (write_object_file(buf, size, blob_type, &ce->oid) < 0) {
43264326
discard_cache_entry(ce);

builtin/update-index.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ static int add_one_path(const struct cache_entry *old, const char *path, int len
280280
memcpy(ce->name, path, len);
281281
ce->ce_flags = create_ce_flags(0);
282282
ce->ce_namelen = len;
283-
fill_stat_cache_info(ce, st);
283+
fill_stat_cache_info(&the_index, ce, st);
284284
ce->ce_mode = ce_mode_from_stat(old, st->st_mode);
285285

286286
if (index_path(&the_index, &ce->oid, path, st,

cache.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,7 @@ int match_stat_data(const struct stat_data *sd, struct stat *st);
826826
int match_stat_data_racy(const struct index_state *istate,
827827
const struct stat_data *sd, struct stat *st);
828828

829-
void fill_stat_cache_info(struct cache_entry *ce, struct stat *st);
829+
void fill_stat_cache_info(struct index_state *istate, struct cache_entry *ce, struct stat *st);
830830

831831
#define REFRESH_REALLY 0x0001 /* ignore_valid */
832832
#define REFRESH_UNMERGED 0x0002 /* allow unmerged */

entry.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ static int write_entry(struct cache_entry *ce,
376376
if (lstat(ce->name, &st) < 0)
377377
return error_errno("unable to stat just-written file %s",
378378
ce->name);
379-
fill_stat_cache_info(ce, &st);
379+
fill_stat_cache_info(state->istate, ce, &st);
380380
ce->ce_flags |= CE_UPDATE_IN_BASE;
381381
mark_fsmonitor_invalid(state->istate, ce);
382382
state->istate->cache_changed |= CE_ENTRY_CHANGED;

read-cache.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ int match_stat_data(const struct stat_data *sd, struct stat *st)
195195
* cache, ie the parts that aren't tracked by GIT, and only used
196196
* to validate the cache.
197197
*/
198-
void fill_stat_cache_info(struct cache_entry *ce, struct stat *st)
198+
void fill_stat_cache_info(struct index_state *istate, struct cache_entry *ce, struct stat *st)
199199
{
200200
fill_stat_data(&ce->ce_stat_data, st);
201201

@@ -728,7 +728,7 @@ int add_to_index(struct index_state *istate, const char *path, struct stat *st,
728728
memcpy(ce->name, path, namelen);
729729
ce->ce_namelen = namelen;
730730
if (!intent_only)
731-
fill_stat_cache_info(ce, st);
731+
fill_stat_cache_info(istate, ce, st);
732732
else
733733
ce->ce_flags |= CE_INTENT_TO_ADD;
734734

@@ -1447,7 +1447,7 @@ static struct cache_entry *refresh_cache_ent(struct index_state *istate,
14471447
updated = make_empty_cache_entry(istate, ce_namelen(ce));
14481448
copy_cache_entry(updated, ce);
14491449
memcpy(updated->name, ce->name, ce->ce_namelen + 1);
1450-
fill_stat_cache_info(updated, &st);
1450+
fill_stat_cache_info(istate, updated, &st);
14511451
/*
14521452
* If ignore_valid is not set, we should leave CE_VALID bit
14531453
* alone. Otherwise, paths marked with --no-assume-unchanged

0 commit comments

Comments
 (0)