Fix global repository field not being cleared (#4083)

dscho · dscho · commit 3a0e80fa3eaa · 2025-01-07T09:52:53.000+01:00
It is checked for w.r.t. global repository struct down in the callstack
in compatibility layer for MinGW before being assigned in the function
that `free()`'d it.
diff --git a/repository.c b/repository.c
@@ -136,7 +136,7 @@ static void repo_set_commondir(struct repository *repo,
 {
 	struct strbuf sb = STRBUF_INIT;
 
-	free(repo->commondir);
+	FREE_AND_NULL(repo->commondir);
 
 	if (commondir) {
 		repo->different_commondir = 1;

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ static void repo_set_commondir(struct repository *repo,`
`136`	`136`	`{`
`137`	`137`	`struct strbuf sb = STRBUF_INIT;`
`138`	`138`
`139`		`- free(repo->commondir);`
	`139`	`+ FREE_AND_NULL(repo->commondir);`
`140`	`140`
`141`	`141`	`if (commondir) {`
`142`	`142`	`repo->different_commondir = 1;`