Skip to content

Commit 458872b

Browse files
committed
ci: remove explicit 'GOPATH' and add note about '-C' option
The 'git-bundle-server' repository is checked out to 'src/git-bundle-server' in anticipation of future dependencies (e.g., Git) being checked out to parallel 'src' directories for use in integration tests. The initial implementation of this workflow included explicit specification of the 'GOPATH' for both 'go build' and 'go vet'; this is not necessary, so remove it. Additionally, add a note about how the upcoming '-C' option should remove the need for an explicit '-C' in each build step. Signed-off-by: Victoria Dye <[email protected]>
1 parent bd840fd commit 458872b

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

.github/workflows/main.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,18 @@ jobs:
1616
with:
1717
path: src/git-bundle-server
1818

19+
# TODO: when the '-C' option is available, remove the 'cd ...'
20+
# See https://github.com/golang/go/issues/50332 for more details
1921
- name: Build
2022
run: |
2123
cd $GITHUB_WORKSPACE/src/git-bundle-server
22-
GOPATH="$GITHUB_WORKSPACE/../../" go build ./cmd/git-bundle-server
23-
GOPATH="$GITHUB_WORKSPACE/../../" go build ./cmd/git-bundle-web-server
24+
go build ./cmd/git-bundle-server
25+
go build ./cmd/git-bundle-web-server
2426
2527
- name: Check style
2628
run: |
2729
cd $GITHUB_WORKSPACE/src/git-bundle-server
28-
GOPATH="$GITHUB_WORKSPACE/../../" go vet ./cmd/git-bundle-server
29-
GOPATH="$GITHUB_WORKSPACE/../../" go vet ./cmd/git-bundle-web-server
30+
go vet ./cmd/git-bundle-server
31+
go vet ./cmd/git-bundle-web-server
3032
3133
# TODO: add automated tests.

0 commit comments

Comments
 (0)