perf(misconf): use json.Valid to check validity of JSON (aquasecurity#7308)

nikpivkin · fhielpos · commit 0162c883d8cf · 2024-12-20T13:42:53.000+01:00
Signed-off-by: nikpivkin &lt;nikita.pivkin@smartforce.io&gt;
diff --git a/pkg/iac/detection/detect.go b/pkg/iac/detection/detect.go
@@ -45,8 +45,8 @@ func init() {
 			return true
 		}
 
-		var content any
-		return json.NewDecoder(r).Decode(&content) == nil
+		b, err := io.ReadAll(r)
+		return err == nil && json.Valid(b)
 	}
 
 	matchers[FileTypeYAML] = func(name string, r io.ReadSeeker) bool {

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,8 @@ func init() {`
`45`	`45`	`return true`
`46`	`46`	`}`
`47`	`47`
`48`		`- var content any`
`49`		`- return json.NewDecoder(r).Decode(&content) == nil`
	`48`	`+ b, err := io.ReadAll(r)`
	`49`	`+ return err == nil && json.Valid(b)`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`matchers[FileTypeYAML] = func(name string, r io.ReadSeeker) bool {`