Skip to content

Server stop working after recent refactor on Windows #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sorasoras opened this issue Mar 9, 2024 · 8 comments · Fixed by #5964
Closed

Server stop working after recent refactor on Windows #5963

sorasoras opened this issue Mar 9, 2024 · 8 comments · Fixed by #5964

Comments

@sorasoras
Copy link

latest branch
server stop working after recently refactor.
I couldn't run server.exe on my Windows build Rocm

PS W:\git\llama.cpp\AVX2\bin> .\server.exe -h
PS W:\git\llama.cpp\AVX2\bin> .\server.exe
PS W:\git\llama.cpp\AVX2\bin>

compile with

cmake .. -G "Ninja" -DCMAKE_BUILD_TYPE=Release -DLLAMA_HIPBLAS=ON -DCMAKE_C_COMPILER="C:/Program Files/AMD/ROCm/5.7/bin/clang.exe" -DCMAKE_CXX_COMPILER="C:/Program Files/AMD/ROCm/5.7/bin/clang++.exe" -DAMDGPU_TARGETS="gfx1100;gfx1030;gfx1031"

@characharm
Copy link
Contributor

The issue is not only with ROCm but also with Vulkan and even AVX2.

@FredericoPerimLopes
Copy link

FredericoPerimLopes commented Mar 9, 2024

I'm also unable to load server on windows build with CUDA.

@ggerganov
Copy link
Member

Seems like a Windows-related problem, so unfortunately I won't be able to help with that.

Could you try to pin-point the exact commit after which it stops working?

@sorasoras
Copy link
Author

Seems like a Windows-related problem, so unfortunately I won't be able to help with that.

Could you try to pin-point the exact commit after which it stops working?

#5882
this one but this is a huge pr

@slaren
Copy link
Member

slaren commented Mar 9, 2024

This happens because ggml_time_us is being called (in server_metrics) before ggml_time_init, which results in a division by zero as timer_freq is zero.

@ggerganov
Copy link
Member

Should be fixed now

@phymbert
Copy link
Collaborator

phymbert commented Mar 9, 2024

Thanks @ggerganov is it worth the effort to add a ci workflow for server tests on Windows ? if yes, I will give it a try next week

@ggerganov
Copy link
Member

Yes, would be useful to have a Windows run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants