ggml-metal : supports_op returns false for ternary types

compilade · compilade · commit b6fc9f03ab53 · 2025-01-11T21:06:49.000-05:00
Maybe not the cleanest way, but hopefully temporary.
diff --git a/ggml/src/ggml-metal/ggml-metal.m b/ggml/src/ggml-metal/ggml-metal.m
@@ -1081,6 +1081,18 @@ static bool ggml_metal_supports_op(const struct ggml_backend_metal_device_contex
             }
         }
     }
+    // TODO: remove once proper support is added.
+    for (size_t i = 0, n = 3; i < n; ++i) {
+        if (op->src[i] != NULL) {
+            switch (op->src[i]->type) {
+                case GGML_TYPE_TQ1_0:
+                case GGML_TYPE_TQ2_0:
+                    return false;
+                default:
+                    break;
+            }
+        }
+    }
 
     switch (op->op) {
         case GGML_OP_UNARY:

Original file line number	Diff line number	Diff line change
`@@ -1081,6 +1081,18 @@ static bool ggml_metal_supports_op(const struct ggml_backend_metal_device_contex`
`1081`	`1081`	`}`
`1082`	`1082`	`}`
`1083`	`1083`	`}`
	`1084`	`+ // TODO: remove once proper support is added.`
	`1085`	`+ for (size_t i = 0, n = 3; i < n; ++i) {`
	`1086`	`+ if (op->src[i] != NULL) {`
	`1087`	`+ switch (op->src[i]->type) {`
	`1088`	`+ case GGML_TYPE_TQ1_0:`
	`1089`	`+ case GGML_TYPE_TQ2_0:`
	`1090`	`+ return false;`
	`1091`	`+ default:`
	`1092`	`+ break;`
	`1093`	`+ }`
	`1094`	`+ }`
	`1095`	`+ }`
`1084`	`1096`
`1085`	`1097`	`switch (op->op) {`
`1086`	`1098`	`case GGML_OP_UNARY:`