Skip to content

Commit 9e20231

Browse files
authored
make : use new flag variables for recent changes (#3019)
1 parent de2fe89 commit 9e20231

File tree

1 file changed

+8
-19
lines changed

1 file changed

+8
-19
lines changed

Makefile

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,11 @@ endif
109109

110110

111111
ifdef LLAMA_CODE_COVERAGE
112-
CXXFLAGS += -fprofile-arcs -ftest-coverage -dumpbase ''
112+
MK_CXXFLAGS += -fprofile-arcs -ftest-coverage -dumpbase ''
113113
endif
114114

115115
ifdef LLAMA_DISABLE_LOGS
116-
CFLAGS += -DLOG_DISABLE_LOGS
117-
CXXFLAGS += -DLOG_DISABLE_LOGS
116+
MK_CPPFLAGS += -DLOG_DISABLE_LOGS
118117
endif # LLAMA_DISABLE_LOGS
119118

120119
# warnings
@@ -124,7 +123,7 @@ MK_CXXFLAGS += -Wall -Wextra -Wpedantic -Wcast-qual -Wno-unused-function -Wno-m
124123

125124
ifeq '' '$(findstring clang++,$(CXX))'
126125
# g++ only
127-
CXXFLAGS += -Wno-format-truncation
126+
MK_CXXFLAGS += -Wno-format-truncation
128127
endif
129128

130129
# OS specific
@@ -188,8 +187,8 @@ endif
188187
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412
189188
# https://github.com/ggerganov/llama.cpp/issues/2922
190189
ifneq '' '$(findstring mingw,$(shell $(CC) -dumpmachine))'
191-
CFLAGS += -Xassembler -muse-unaligned-vector-move
192-
CXXFLAGS += -Xassembler -muse-unaligned-vector-move
190+
MK_CFLAGS += -Xassembler -muse-unaligned-vector-move
191+
MK_CXXFLAGS += -Xassembler -muse-unaligned-vector-move
193192
endif
194193

195194
ifneq ($(filter aarch64%,$(UNAME_M)),)
@@ -226,8 +225,8 @@ ifneq ($(filter ppc64%,$(UNAME_M)),)
226225
endif
227226

228227
else
229-
CFLAGS += -march=rv64gcv -mabi=lp64d
230-
CXXFLAGS += -march=rv64gcv -mabi=lp64d
228+
MK_CFLAGS += -march=rv64gcv -mabi=lp64d
229+
MK_CXXFLAGS += -march=rv64gcv -mabi=lp64d
231230
endif
232231

233232
ifndef LLAMA_NO_K_QUANTS
@@ -247,16 +246,6 @@ ifndef LLAMA_NO_ACCELERATE
247246
endif
248247
endif # LLAMA_NO_ACCELERATE
249248

250-
ifdef LLAMA_METAL
251-
# By default - use GPU acceleration on Mac OS
252-
ifeq ($(UNAME_S),Darwin)
253-
CFLAGS += -DGGML_USE_METAL #-DGGML_METAL_NDEBUG
254-
CXXFLAGS += -DGGML_USE_METAL
255-
LDFLAGS += -framework Foundation -framework Metal -framework MetalKit
256-
OBJS += ggml-metal.o
257-
endif
258-
endif # LLAMA_METAL
259-
260249
ifdef LLAMA_MPI
261250
MK_CPPFLAGS += -DGGML_USE_MPI
262251
MK_CFLAGS += -Wno-cast-qual
@@ -368,7 +357,7 @@ ggml-cuda.o: ggml-cuda.cu ggml-cuda.h
368357
endif # LLAMA_HIPBLAS
369358

370359
ifdef LLAMA_METAL
371-
MK_CPPFLAGS += -DGGML_USE_METAL #-DGGML_METAL_NDEBUG
360+
MK_CPPFLAGS += -DGGML_USE_METAL
372361
MK_LDFLAGS += -framework Foundation -framework Metal -framework MetalKit
373362
OBJS += ggml-metal.o
374363
endif # LLAMA_METAL

0 commit comments

Comments
 (0)