You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general, it seems to work, but I think it fails for unicode character support. Hopefully, someone can help with that
186
177
- I don't know yet how much the quantization affects the quality of the generated text
187
178
- Probably the token sampling can be improved
188
179
- The Accelerate framework is actually currently unused since I found that for tensor shapes typical for the Decoder,
@@ -192,16 +183,15 @@ Note the use of `--color` to distinguish between user input and generated text.
192
183
193
184
### Contributing
194
185
195
-
- There are 2 git branches: [master](https://github.com/ggerganov/llama.cpp/commits/master) and [dev](https://github.com/ggerganov/llama.cpp/commits/dev)
196
-
- Contributors can open PRs to either one
197
-
- Collaborators can push straight into `dev`, but need to open a PR to get stuff to `master`
186
+
- Contributors can open PRs
187
+
- Collaborators can push to branches in the `llama.cpp` repo
198
188
- Collaborators will be invited based on contributions
199
-
-`dev` branch is considered unstable
200
-
-`master` branch is considered stable and approved. 3-rd party projects should use the `master` branch
201
189
202
-
General principles to follow when writing code:
190
+
### Coding guide-lines
203
191
204
192
- Avoid adding third-party dependencies, extra files, extra headers, etc.
205
193
- Always consider cross-compatibility with other operating systems and architectures
206
194
- Avoid fancy looking modern STL constructs, use basic for loops, avoid templates, keep it simple
207
195
- There are no strict rules for the code style, but try to follow the patterns in the code (indentation, spaces, etc.). Vertical alignment makes things more readable and easier to batch edit
196
+
- Clean-up any tailing whitespaces, use 4 spaces indentation, brackets on same line, `int * var`
197
+
- Look at the [good first issues](https://github.com/ggerganov/llama.cpp/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) for tasks
0 commit comments