Skip to content

Commit 7ca90a8

Browse files
committed
Minor, plus rebase on master
1 parent aafce18 commit 7ca90a8

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ggml.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2000,7 +2000,7 @@ static const quantize_fns_t quantize_fns[GGML_TYPE_COUNT] = {
20002000
[GGML_TYPE_Q4_3] = {
20012001
.dequantize_row_q = dequantize_row_q4_3,
20022002
.quantize_row_q = quantize_row_q4_3,
2003-
.quantize_row_q_reference = (quantize_row_q_t) quantize_row_q4_3_reference, // TODO: RMSE optimization
2003+
.quantize_row_q_reference = (quantize_row_q_t) quantize_row_q4_3_reference,
20042004
.quantize_row_q_dot = quantize_row_q8_0,
20052005
.vec_dot_q = ggml_vec_dot_q4_3_q8_0,
20062006
},

tests/test-quantize.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
#include <math.h>
55

66
int main(void) {
7+
8+
// Sorry, but I have to disable these for RMSE-optimized quantization
9+
#ifdef GGML_NO_RMSE
710
#define QK 32
811
float src[QK];
912
uint8_t dst[24];
@@ -13,8 +16,6 @@ int main(void) {
1316
src[i] = (float)(i + 1);
1417
}
1518

16-
// Sorry, but I have to disable these for RMSE-optimized quantization
17-
#ifdef GGML_NO_RMSE
1819
size_t size = ggml_quantize_q4_0(src, dst, QK, QK, hist);
1920
assert(size == 20);
2021
float max_result = ((float *)dst)[0];

0 commit comments

Comments
 (0)