Skip to content

Commit 71c1121

Browse files
authored
examples : sprintf -> snprintf (#8434)
* examples : sprintf -> snprintf ggml-ci * examples : use sizeof() instead of hardcoded constants
1 parent 370b1f7 commit 71c1121

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

examples/eval-callback/eval-callback.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ static bool ggml_debug(struct ggml_tensor * t, bool ask, void * user_data) {
9999

100100
char src1_str[128] = {0};
101101
if (src1) {
102-
sprintf(src1_str, "%s{%s}", src1->name, ggml_ne_string(src1).c_str());
102+
snprintf(src1_str, sizeof(src1_str), "%s{%s}", src1->name, ggml_ne_string(src1).c_str());
103103
}
104104

105105
printf("%s: %24s = (%s) %10s(%s{%s}, %s}) = {%s}\n", __func__,

examples/gguf-hash/gguf-hash.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ static hash_exit_code_t gguf_hash(const hash_params & hash_params) {
347347
char hex_result[17];
348348
for (int offset = 0; offset < 8; offset++) {
349349
unsigned int shift_bits_by = (8 * (8 - offset - 1));
350-
sprintf( ( hex_result + (2*offset)), "%02x", (unsigned char) (hash >> shift_bits_by)&0xff);
350+
snprintf( ( hex_result + (2*offset)), sizeof(hex_result) - (2*offset), "%02x", (unsigned char) (hash >> shift_bits_by)&0xff);
351351
}
352352

353353
if (hash_params.manifest_is_usable) {
@@ -384,7 +384,7 @@ static hash_exit_code_t gguf_hash(const hash_params & hash_params) {
384384

385385
char hex_result[41] = {0};
386386
for (int offset = 0; offset < 20; offset++) {
387-
sprintf( ( hex_result + (2*offset)), "%02x", result[offset]&0xff);
387+
snprintf( ( hex_result + (2*offset)), sizeof(hex_result) - (2*offset), "%02x", result[offset]&0xff);
388388
}
389389

390390
if (hash_params.manifest_is_usable) {
@@ -421,7 +421,7 @@ static hash_exit_code_t gguf_hash(const hash_params & hash_params) {
421421

422422
char hex_result[SHA256_DIGEST_SIZE * 2 + 1] = {0};
423423
for (int offset = 0; offset < SHA256_DIGEST_SIZE; offset++) {
424-
sprintf( ( hex_result + (2*offset)), "%02x", result[offset]&0xff);
424+
snprintf( ( hex_result + (2*offset)), sizeof(hex_result) - (2*offset), "%02x", result[offset]&0xff);
425425
}
426426

427427
if (hash_params.manifest_is_usable) {
@@ -460,7 +460,7 @@ static hash_exit_code_t gguf_hash(const hash_params & hash_params) {
460460
char hex_result[17];
461461
for (int offset = 0; offset < 8; offset++) {
462462
unsigned int shift_bits_by = (8 * (8 - offset - 1));
463-
sprintf( ( hex_result + (2*offset)), "%02x", (unsigned char) (hash >> shift_bits_by)&0xff);
463+
snprintf( ( hex_result + (2*offset)), sizeof(hex_result) - (2*offset), "%02x", (unsigned char) (hash >> shift_bits_by)&0xff);
464464
}
465465

466466
if (hash_params.manifest_is_usable) {
@@ -490,7 +490,7 @@ static hash_exit_code_t gguf_hash(const hash_params & hash_params) {
490490

491491
char hex_result[41];
492492
for (int offset = 0; offset < 20; offset++) {
493-
sprintf( ( hex_result + (2*offset)), "%02x", result[offset]&0xff);
493+
snprintf( ( hex_result + (2*offset)), sizeof(hex_result) - (2*offset), "%02x", result[offset]&0xff);
494494
}
495495

496496
if (hash_params.manifest_is_usable) {
@@ -520,7 +520,7 @@ static hash_exit_code_t gguf_hash(const hash_params & hash_params) {
520520

521521
char hex_result[SHA256_DIGEST_SIZE * 2 + 1] = {0};
522522
for (int offset = 0; offset < SHA256_DIGEST_SIZE; offset++) {
523-
sprintf( ( hex_result + (2*offset)), "%02x", result[offset]&0xff);
523+
snprintf( ( hex_result + (2*offset)), sizeof(hex_result) - (2*offset), "%02x", result[offset]&0xff);
524524
}
525525

526526
if (hash_params.manifest_is_usable) {
@@ -552,7 +552,7 @@ static hash_exit_code_t gguf_hash(const hash_params & hash_params) {
552552
generate_uuidv5(result, uuid);
553553

554554
char string_buffer[37] = {0};
555-
sprintf(string_buffer, "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x",
555+
snprintf(string_buffer, sizeof(string_buffer), "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x",
556556
uuid[0], uuid[1], uuid[2], uuid[3],
557557
uuid[4], uuid[5], uuid[6], uuid[7],
558558
uuid[8], uuid[9], uuid[10], uuid[11],

0 commit comments

Comments
 (0)