Skip to content

Commit 670fb48

Browse files
committed
metal : fix "supports family" call
1 parent 58265e5 commit 670fb48

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

ggml-metal.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,13 @@ GGML_API ggml_backend_t ggml_backend_metal_init(void);
9898

9999
GGML_API bool ggml_backend_is_metal(ggml_backend_t backend);
100100

101+
GGML_API void ggml_backend_metal_set_n_cb(ggml_backend_t backend, int n_cb);
101102
GGML_API ggml_backend_buffer_type_t ggml_backend_metal_buffer_type(void);
102103

103-
GGML_API void ggml_backend_metal_set_n_cb(ggml_backend_t backend, int n_cb);
104+
// helper to check if the device supports a specific family
105+
// ideally, the user code should be doing these checks
106+
// ref: https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf
107+
GGML_API bool ggml_backend_metal_supports_family(ggml_backend_t backend, int family);
104108

105109
#ifdef __cplusplus
106110
}

ggml-metal.m

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2092,6 +2092,14 @@ void ggml_backend_metal_set_n_cb(ggml_backend_t backend, int n_cb) {
20922092
ggml_metal_set_n_cb(ctx, n_cb);
20932093
}
20942094

2095+
bool ggml_backend_metal_supports_family(ggml_backend_t backend, int family) {
2096+
GGML_UNUSED(ggml_backend_is_metal(backend));
2097+
2098+
struct ggml_metal_context * ctx = (struct ggml_metal_context *)backend->context;
2099+
2100+
return [ctx->device supportsFamily:(MTLGPUFamilyApple1 + family - 1)];
2101+
}
2102+
20952103
ggml_backend_t ggml_backend_reg_metal_init(const char * params, void * user_data); // silence warning
20962104

20972105
ggml_backend_t ggml_backend_reg_metal_init(const char * params, void * user_data) {

0 commit comments

Comments
 (0)