ggml : fix bug in ggml_compute_forward_sum_f32 (#1162)

xaedes · web-flow · commit 54bb60e26858 · 2023-04-24T23:02:02.000+02:00
The sum over all rows is now computed instead of just the last row
diff --git a/ggml.c b/ggml.c
@@ -6779,15 +6779,20 @@ static void ggml_compute_forward_sum_f32(
     const size_t nb02 = src0->nb[2];
     const size_t nb03 = src0->nb[3];
 
+    ggml_float sum     = 0;
+    float      row_sum = 0;
+
     for (int64_t i03 = 0; i03 < ne03; i03++) {
         for (int64_t i02 = 0; i02 < ne02; i02++) {
             for (int64_t i01 = 0; i01 < ne01; i01++) {
                 ggml_vec_sum_f32(ne00,
-                        (float *) (dst->data),
+                        &row_sum,
                         (float *) ((char *) src0->data + i01*nb01 + i02*nb02 + i03*nb03));
+                sum += row_sum;
             }
         }
     }
+    ((float *) dst->data)[0] = sum;
 }
 
 static void ggml_compute_forward_sum(

Original file line number	Diff line number	Diff line change
`@@ -6779,15 +6779,20 @@ static void ggml_compute_forward_sum_f32(`
`6779`	`6779`	`const size_t nb02 = src0->nb[2];`
`6780`	`6780`	`const size_t nb03 = src0->nb[3];`
`6781`	`6781`
	`6782`	`+ ggml_float sum = 0;`
	`6783`	`+ float row_sum = 0;`
	`6784`	`+`
`6782`	`6785`	`for (int64_t i03 = 0; i03 < ne03; i03++) {`
`6783`	`6786`	`for (int64_t i02 = 0; i02 < ne02; i02++) {`
`6784`	`6787`	`for (int64_t i01 = 0; i01 < ne01; i01++) {`
`6785`	`6788`	`ggml_vec_sum_f32(ne00,`
`6786`		`- (float *) (dst->data),`
	`6789`	`+ &row_sum,`
`6787`	`6790`	`(float ) ((char ) src0->data + i01nb01 + i02nb02 + i03*nb03));`
	`6791`	`+ sum += row_sum;`
`6788`	`6792`	`}`
`6789`	`6793`	`}`
`6790`	`6794`	`}`
	`6795`	`+ ((float *) dst->data)[0] = sum;`
`6791`	`6796`	`}`
`6792`	`6797`
`6793`	`6798`	`static void ggml_compute_forward_sum(`