refactor(naga): improve diags. for unexpected scalars in pipeline_constants::map_value_to_literal

ErichDonGubler · ErichDonGubler · commit 2c9e80cb8492 · 2025-06-13T14:44:29.000+09:00
diff --git a/naga/src/back/pipeline_constants.rs b/naga/src/back/pipeline_constants.rs
@@ -979,7 +979,10 @@ fn map_value_to_literal(value: f64, scalar: Scalar) -> Result<Literal, PipelineC
 
             Ok(Literal::F64(value))
         }
-        _ => unreachable!(),
+        Scalar::ABSTRACT_FLOAT | Scalar::ABSTRACT_INT => {
+            unreachable!("abstract values should not be validated out of override processing")
+        }
+        _ => unreachable!("unrecognized scalar type for override"),
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -979,7 +979,10 @@ fn map_value_to_literal(value: f64, scalar: Scalar) -> Result<Literal, PipelineC`
`979`	`979`
`980`	`980`	`Ok(Literal::F64(value))`
`981`	`981`	`}`
`982`		`- _ => unreachable!(),`
	`982`	`+ Scalar::ABSTRACT_FLOAT \| Scalar::ABSTRACT_INT => {`
	`983`	`+ unreachable!("abstract values should not be validated out of override processing")`
	`984`	`+ }`
	`985`	`+ _ => unreachable!("unrecognized scalar type for override"),`
`983`	`986`	`}`
`984`	`987`	`}`
`985`	`988`