From 5d6f8acf8c1e0918a43391322e292d26dcf95fce Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 16 Oct 2023 15:35:25 +0200 Subject: [PATCH 1/3] feat(platforms): Add Astro as a platform (frontend) --- fixtures/integration-docs/_platforms.json | 6 ++++++ fixtures/integration-docs/javascript-astro.json | 6 ++++++ .../events/interfaces/crashContent/exception/utils.tsx | 1 + static/app/components/events/interfaces/spans/utils.tsx | 1 + .../app/components/onboarding/frameworkSuggestionModal.tsx | 1 + static/app/data/platformCategories.tsx | 4 ++++ static/app/data/platformPickerCategories.tsx | 1 + static/app/data/platforms.tsx | 7 +++++++ static/app/icons/icons.stories.tsx | 1 + static/app/types/project.tsx | 1 + 10 files changed, 29 insertions(+) create mode 100644 fixtures/integration-docs/javascript-astro.json diff --git a/fixtures/integration-docs/_platforms.json b/fixtures/integration-docs/_platforms.json index d12d4e4c80072a..d92d47cb5bcb0a 100644 --- a/fixtures/integration-docs/_platforms.json +++ b/fixtures/integration-docs/_platforms.json @@ -134,6 +134,12 @@ "id": "javascript-angularjs", "name": "AngularJS" }, + { + "link": "https://docs.sentry.io/platforms/javascript/guides/astro/", + "type": "framework", + "id": "javascript-astro", + "name": "Astro" + }, { "link": "https://docs.getsentry.com/clients/javascript/integrations/backbone/", "type": "framework", diff --git a/fixtures/integration-docs/javascript-astro.json b/fixtures/integration-docs/javascript-astro.json new file mode 100644 index 00000000000000..305c2a1cdaddac --- /dev/null +++ b/fixtures/integration-docs/javascript-astro.json @@ -0,0 +1,6 @@ +{ + "html": "
\n", + "link": "https://docs.sentry.io/platforms/javascript/guides/astro/", + "id": "javascript-astro", + "name": "Astro" +} diff --git a/static/app/components/events/interfaces/crashContent/exception/utils.tsx b/static/app/components/events/interfaces/crashContent/exception/utils.tsx index cc46f77b247d35..c352c02a0ef024 100644 --- a/static/app/components/events/interfaces/crashContent/exception/utils.tsx +++ b/static/app/components/events/interfaces/crashContent/exception/utils.tsx @@ -35,4 +35,5 @@ export const sourceMapSdkDocsMap: Record = { 'sentry.javascript.svelte': 'svelte', 'sentry.javascript.sveltekit': 'sveltekit', 'sentry.javascript.react-native': 'react-native', + 'sentry.javascript.atro': 'astro', }; diff --git a/static/app/components/events/interfaces/spans/utils.tsx b/static/app/components/events/interfaces/spans/utils.tsx index 33f7e0b38e9e50..220fe37fd271d5 100644 --- a/static/app/components/events/interfaces/spans/utils.tsx +++ b/static/app/components/events/interfaces/spans/utils.tsx @@ -668,6 +668,7 @@ export function isEventFromBrowserJavaScriptSDK( 'sentry.javascript.remix', 'sentry.javascript.svelte', 'sentry.javascript.sveltekit', + 'sentry.javascript.astro', ].includes(sdkName.toLowerCase()); } diff --git a/static/app/components/onboarding/frameworkSuggestionModal.tsx b/static/app/components/onboarding/frameworkSuggestionModal.tsx index 3da770bab1cc92..707b1b44a23882 100644 --- a/static/app/components/onboarding/frameworkSuggestionModal.tsx +++ b/static/app/components/onboarding/frameworkSuggestionModal.tsx @@ -55,6 +55,7 @@ export const topJavascriptFrameworks = [ 'javascript-svelte', 'javascript-sveltekit', 'javascript-remix', + 'javascript-astro', ]; const topPythonFrameworks = [ diff --git a/static/app/data/platformCategories.tsx b/static/app/data/platformCategories.tsx index 52847507597ab0..cea2342f1edc62 100644 --- a/static/app/data/platformCategories.tsx +++ b/static/app/data/platformCategories.tsx @@ -16,6 +16,7 @@ export const frontend: PlatformKey[] = [ 'javascript', 'javascript-angular', 'javascript-angularjs', + 'javascript-astro', 'javascript-backbone', 'javascript-ember', 'javascript-gatsby', @@ -245,6 +246,7 @@ export const releaseHealth: PlatformKey[] = [ 'javascript-react', 'javascript-angular', 'javascript-angularjs', + 'javascript-astro', 'javascript-backbone', 'javascript-ember', 'javascript-gatsby', @@ -296,6 +298,7 @@ export const replayPlatforms: readonly PlatformKey[] = [ 'electron', 'javascript-angular', // 'javascript-angularjs', // Unsupported, angularjs requires the v6.x core SDK + 'javascript-astro', 'javascript-backbone', 'javascript-capacitor', 'javascript-electron', @@ -320,6 +323,7 @@ export const replayOnboardingPlatforms: readonly PlatformKey[] = [ 'capacitor', 'electron', 'javascript-angular', + 'javascript-astro', // 'javascript-angularjs', // Unsupported, angularjs requires the v6.x core SDK // 'javascript-backbone', // No docs yet 'javascript-capacitor', diff --git a/static/app/data/platformPickerCategories.tsx b/static/app/data/platformPickerCategories.tsx index 23abf2c6ca678d..fb190af9f257d8 100644 --- a/static/app/data/platformPickerCategories.tsx +++ b/static/app/data/platformPickerCategories.tsx @@ -33,6 +33,7 @@ const browser: Set = new Set([ 'dart', 'javascript', 'javascript-angular', + 'javascript-astro', 'javascript-ember', 'javascript-gatsby', 'javascript-nextjs', diff --git a/static/app/data/platforms.tsx b/static/app/data/platforms.tsx index 3a6fed3b52f392..3313e4f153a989 100644 --- a/static/app/data/platforms.tsx +++ b/static/app/data/platforms.tsx @@ -263,6 +263,13 @@ const platforms: PlatformIntegration[] = [ language: 'javascript', link: 'https://docs.sentry.io/platforms/javascript/guides/angular/', }, + { + id: 'javascript-astro', + name: 'Astro', + type: 'framework', + language: 'javascript', + link: 'https://docs.sentry.io/platforms/javascript/guides/astro/', + }, { id: 'javascript-ember', name: 'Ember', diff --git a/static/app/icons/icons.stories.tsx b/static/app/icons/icons.stories.tsx index 2f6284287bafde..8172ca3268c3d7 100644 --- a/static/app/icons/icons.stories.tsx +++ b/static/app/icons/icons.stories.tsx @@ -72,6 +72,7 @@ const platformToIcon = { javascript: 'javascript', 'javascript-angular': 'angularjs', 'javascript-angularjs': 'angularjs', + 'javascript-astro': 'astro', 'javascript-backbone': 'backbone', 'javascript-browser': 'javascript', 'javascript-capacitor': 'capacitor', diff --git a/static/app/types/project.tsx b/static/app/types/project.tsx index 9d3e63519f1d4c..d5045b00fa68bb 100644 --- a/static/app/types/project.tsx +++ b/static/app/types/project.tsx @@ -176,6 +176,7 @@ export type PlatformKey = | 'javascript' | 'javascript-angular' | 'javascript-angularjs' + | 'javascript-astro' | 'javascript-backbone' | 'javascript-browser' | 'javascript-capacitor' From bab280ad46b12f769ad57e9fa492c93f531fd29b Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 17 Oct 2023 11:58:16 +0200 Subject: [PATCH 2/3] Update static/app/data/platformPickerCategories.tsx Co-authored-by: ArthurKnaus --- static/app/data/platformPickerCategories.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/static/app/data/platformPickerCategories.tsx b/static/app/data/platformPickerCategories.tsx index fb190af9f257d8..23abf2c6ca678d 100644 --- a/static/app/data/platformPickerCategories.tsx +++ b/static/app/data/platformPickerCategories.tsx @@ -33,7 +33,6 @@ const browser: Set = new Set([ 'dart', 'javascript', 'javascript-angular', - 'javascript-astro', 'javascript-ember', 'javascript-gatsby', 'javascript-nextjs', From 2aab0593bc3166868a60f831c4439381a86df9b3 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 17 Oct 2023 17:33:27 +0200 Subject: [PATCH 3/3] fix temporarily failing test --- static/app/data/platforms.tsx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/static/app/data/platforms.tsx b/static/app/data/platforms.tsx index 3313e4f153a989..dfa0e10c2ab427 100644 --- a/static/app/data/platforms.tsx +++ b/static/app/data/platforms.tsx @@ -263,13 +263,14 @@ const platforms: PlatformIntegration[] = [ language: 'javascript', link: 'https://docs.sentry.io/platforms/javascript/guides/angular/', }, - { - id: 'javascript-astro', - name: 'Astro', - type: 'framework', - language: 'javascript', - link: 'https://docs.sentry.io/platforms/javascript/guides/astro/', - }, + // TODO: comment back in when we have a getting-started page for Astro + // { + // id: 'javascript-astro', + // name: 'Astro', + // type: 'framework', + // language: 'javascript', + // link: 'https://docs.sentry.io/platforms/javascript/guides/astro/', + // }, { id: 'javascript-ember', name: 'Ember',